Skip to content

Conversation

EmilienM
Copy link
Contributor

@EmilienM EmilienM commented Mar 4, 2025

What this PR does / why we need it:

New versions of crypto require a new version of Go (1.23) and we don't want to bump go in release-0.11.

@k8s-ci-robot k8s-ci-robot requested review from lentzi90 and mdbooth March 4, 2025 16:21
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 4, 2025
Copy link

netlify bot commented Mar 4, 2025

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 2eff8ea
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/67c875d7c77eca000952fc2d
😎 Deploy Preview https://deploy-preview-2445--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 5, 2025
@mdbooth
Copy link
Contributor

mdbooth commented Mar 5, 2025

@EmilienM This PR is against main, but the title suggests you intended it to be against a release branch?

@lentzi90
Copy link
Contributor

lentzi90 commented Mar 5, 2025

It configures dependabot to not suggest bumps on release-0.11 for crypto. The target branch is a bit above in the diff

@mdbooth
Copy link
Contributor

mdbooth commented Mar 5, 2025

It configures dependabot to not suggest bumps on release-0.11 for crypto. The target branch is a bit above in the diff

Thanks. I should really read the dependabot docs one of these days!

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2025
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 5, 2025
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@EmilienM EmilienM added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 5, 2025
@EmilienM EmilienM merged commit eec5037 into kubernetes-sigs:main Mar 5, 2025
8 checks passed
@EmilienM EmilienM deleted the goversion branch March 5, 2025 16:36
@github-project-automation github-project-automation bot moved this from Inbox to Done in CAPO Roadmap Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants