🐛 New IPAddressClaim.ObjectMeta.Labels nil map assign panic

[mikaelgron]

What this PR does / why we need it:

When an IPAddressClaim is created and the openstackserver has a cluster name label, the capo controller panics because the Labels map is nil by default.

This PR creates an empty Lables map on new IPAddressClaim ObjectMeta.

TODOs:

• squashed commits

/hold

[k8s-ci-robot]

Hi @mikaelgron. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[netlify]

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name	Link
🔨 Latest commit	b7b2d05
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/677e9615a3d1e70008cade77
😎 Deploy Preview	https://deploy-preview-2352--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[mdbooth]

/ok-to-test
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mdbooth]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mdbooth]

/cherry-pick release-0.11

[k8s-infra-cherrypick-robot]

@mdbooth: once the present PR merges, I will cherry-pick it on top of release-0.11 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mdbooth]

The linter didn't like the formatting:

controllers/openstackserver_controller.go:605: File is not `gci`-ed with --skip-generated -s standard -s default -s prefix(github.com/k-orc/openstack-resource-controller) -s prefix(sigs.k8s.io/cluster-api-provider-openstack) (gci)
			Labels: map[string]string{},

Can't immediately see why, but if you run make lint-update it will almost certain just fix it to make itself happy.

[mikaelgron]

@mdbooth 'twas indentation

[mdbooth]

/lgtm
/hold cancel

[k8s-infra-cherrypick-robot]

@mdbooth: new pull request created: #2354

In response to this:

/cherry-pick release-0.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.