🌱 E2E: Use CAPI production images and skip cert-manager pre-pull #2295
Conversation
Use CAPI production images instead of from GCR. Don't prepull cert-manager. We always let these images get out of sync, causing us to pull double instead of saving anything. We end up with different tags in e2e_conf.yaml and in the Makefile. Additionally, CAPI may change what version is installed by clusterctl by default, causing us to pull *two* wrong versions and then install a third if we don't remember to check when bumping CAPI. Signed-off-by: Lennart Jern <[email protected]>
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
cncf-cla: yes
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
that's a great change, thanks a lot for taking care of that @lentzi90 . I think we can backport it as the version of CAPI is the same for now. |
|
@EmilienM: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EmilienM The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/test pull-cluster-api-provider-openstack-e2e-test |
2 similar comments
|
/test pull-cluster-api-provider-openstack-e2e-test |
|
/test pull-cluster-api-provider-openstack-e2e-test |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
@EmilienM: new pull request created: #2300 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
Use CAPI production images instead of from GCR.
Don't pre-pull cert-manager. We always let these images get out of sync, causing us to pull double instead of saving anything. We end up with different tags in e2e_conf.yaml and in the Makefile. Additionally, CAPI may change what version is installed by clusterctl by default, causing us to pull two wrong versions and then install a third if we don't remember to check when bumping CAPI.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
/hold