Skip to content

🌱 E2E: Bump Kubernetes to v1.29.5 #2103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2024
Merged

🌱 E2E: Bump Kubernetes to v1.29.5 #2103

merged 1 commit into from
May 29, 2024

Conversation

lentzi90
Copy link
Contributor

What this PR does / why we need it:

Bumping the Kubernetes versions used in e2e tests.
Upgrades are now from v1.28.5 to v1.29.5

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • if necessary:
    • includes documentation
    • adds unit tests

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 28, 2024
@k8s-ci-robot k8s-ci-robot requested review from EmilienM and jichenjc May 28, 2024 09:15
@netlify Netlify
Copy link

netlify bot commented May 28, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 94b2c1f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/6656dac6e03ddd000847f16f
😎 Deploy Preview https://deploy-preview-2103--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lentzi90
Copy link
Contributor Author

/test pull-cluster-api-provider-openstack-e2e-optional-test

@k8s-ci-robot
Copy link
Contributor

@lentzi90: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-openstack-build
  • /test pull-cluster-api-provider-openstack-e2e-test
  • /test pull-cluster-api-provider-openstack-test

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-openstack-conformance-test
  • /test pull-cluster-api-provider-openstack-e2e-full-test

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-openstack-build
  • pull-cluster-api-provider-openstack-e2e-test
  • pull-cluster-api-provider-openstack-test

In response to this:

/test pull-cluster-api-provider-openstack-e2e-optional-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lentzi90
Copy link
Contributor Author

/test pull-cluster-api-provider-openstack-e2e-full-test

@jichenjc
Copy link
Contributor

/lgtm

k8s 1.30 is out, not sure whether we want to catch that?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 28, 2024
@lentzi90
Copy link
Contributor Author

Yes I'll build images for that next. Just wanted to do it in step 😅

@lentzi90
Copy link
Contributor Author

I was a bit too fast triggering the tests... The image was still uploading 😂

@lentzi90
Copy link
Contributor Author

/test pull-cluster-api-provider-openstack-e2e-test

@lentzi90
Copy link
Contributor Author

/test pull-cluster-api-provider-openstack-e2e-full-test

EmilienM
EmilienM reviewed May 28, 2024
View reviewed changes
@lentzi90 lentzi90 force-pushed the lentzi90/bump-k8s-v1.29.5 branch from d10d9da to de79ee6 Compare May 29, 2024 06:04
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 29, 2024
@lentzi90
Copy link
Contributor Author

/test pull-cluster-api-provider-openstack-e2e-full-test

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 29, 2024
@lentzi90
E2E: Bump Kubernetes to v1.29.5
94b2c1f 
Upgrades are now from v1.28.5 to v1.29.5

Signed-off-by: Lennart Jern <[email protected]>
@lentzi90 lentzi90 force-pushed the lentzi90/bump-k8s-v1.29.5 branch from de79ee6 to 94b2c1f Compare May 29, 2024 07:35
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 29, 2024
@lentzi90
Copy link
Contributor Author

/test pull-cluster-api-provider-openstack-e2e-full-test

@lentzi90
Copy link
Contributor Author

@tormath1 is something needed for the sysext test? It has failed now twice so I suspect I have missed something 🤔

@tormath1
Copy link
Contributor

tormath1 commented May 29, 2024 •
edited
Loading

@tormath1 is something needed for the sysext test? It has failed now twice so I suspect I have missed something 🤔

Should be good now! The sysext image for Kubernetes 1.29.5 was missing: it's now available https://github.com/flatcar/sysext-bakery/releases/tag/latest

EDIT: 1.30 and 1.30.1 are available too if you want to bump later.

@lentzi90
Copy link
Contributor Author

/test pull-cluster-api-provider-openstack-e2e-test

@EmilienM
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 29, 2024
@EmilienM
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 29, 2024
@lentzi90
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2024
@k8s-ci-robot k8s-ci-robot merged commit fa97253 into kubernetes-sigs:main May 29, 2024
@lentzi90 lentzi90 deleted the lentzi90/bump-k8s-v1.29.5 branch May 29, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmilienM EmilienM EmilienM left review comments

@jichenjc jichenjc Awaiting requested review from jichenjc

Assignees

@EmilienM EmilienM

@jichenjc jichenjc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
CAPO Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lentzi90 @k8s-ci-robot @jichenjc @tormath1 @EmilienM