Skip to content

🐛 Update e2e testing image of CAPI version from 1.5.0 to 1.5.1 #1754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 23, 2023
Merged

🐛 Update e2e testing image of CAPI version from 1.5.0 to 1.5.1 #1754

merged 1 commit into from
Nov 23, 2023
+12 −9

Conversation

maxrantil
Copy link

What this PR does / why we need it:
Fix misconfigured logger

Which issue(s) this PR fixes
Fixes #1698

TODOs:

  • squashed commits
  • if necessary:
    • includes documentation
    • adds unit tests

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 22, 2023
@netlify Netlify
Copy link

netlify bot commented Nov 22, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit ee8ed65
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/655f110fd8903d0008817eaf
😎 Deploy Preview https://deploy-preview-1754--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Nov 22, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: maxrantil / name: Max Rantil (ee8ed65)

@k8s-ci-robot
Copy link
Contributor

Welcome @maxrantil!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-openstack 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-openstack has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 22, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @maxrantil. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Nov 22, 2023
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 22, 2023
@lentzi90
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 22, 2023
@lentzi90
Copy link
Contributor

Please check all occurrences in the file! There are many places with the same version. One for each of bootstrap, control plane and core providers, and also for the images for them.

@maxrantil maxrantil force-pushed the e2e-misconfigured-logger/max branch from b812eb9 to e6de3ce Compare November 22, 2023 11:06
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 22, 2023
@maxrantil
Copy link
Author

/retest

@jichenjc
Copy link
Contributor

I think we are only updating the testing image of CAPI? not the CAPI itself in the code from the change.. so the commit message might need update?

@maxrantil maxrantil force-pushed the e2e-misconfigured-logger/max branch from e6de3ce to 6278fb0 Compare November 23, 2023 06:10
@maxrantil maxrantil changed the title 🐛 Update CAPI version from 1.5.0 to 1.5.1 🐛 Update e2e testing image of CAPI version from 1.5.0 to 1.5.1 Nov 23, 2023
@maxrantil
Copy link
Author

Yes that is right. Thanks you for the feedback @jichenjc . It is now changed.

@lentzi90
Copy link
Contributor

Looks like it was not enough 😞
https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-provider-openstack/1754/pull-cluster-api-provider-openstack-e2e-test/1727570398410706944#1:build-log.txt%3A1930

[controller-runtime] log.SetLogger(...) was never called, logs will not be displayed:

I had hoped that it would be enough to just bump the CAPI version but it could be that we have to do something on our side also.

@maxrantil maxrantil force-pushed the e2e-misconfigured-logger/max branch from 6278fb0 to e71ce75 Compare November 23, 2023 07:46
lentzi90
lentzi90 reviewed Nov 23, 2023
View reviewed changes
@maxrantil maxrantil force-pushed the e2e-misconfigured-logger/max branch from e71ce75 to ee8ed65 Compare November 23, 2023 08:45
lentzi90
lentzi90 reviewed Nov 23, 2023
View reviewed changes
Copy link
Contributor

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good now from what I can see in the logs!
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90, maxrantil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2023
@jichenjc
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 23, 2023
@lentzi90
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 23, 2023
@k8s-ci-robot k8s-ci-robot merged commit fc7ba6e into kubernetes-sigs:main Nov 23, 2023
@kashifest kashifest mentioned this pull request May 17, 2024
Closed
@lentzi90 lentzi90 deleted the e2e-misconfigured-logger/max branch April 17, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lentzi90 lentzi90 lentzi90 left review comments

@mdbooth mdbooth Awaiting requested review from mdbooth

@seanschneeweiss seanschneeweiss Awaiting requested review from seanschneeweiss

Assignees

@jichenjc jichenjc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

E2e misconfigured logger
4 participants
@maxrantil @k8s-ci-robot @lentzi90 @jichenjc