✨ Add cache on provider scope #1688

alexandrevilain · 2023-09-27T15:42:31Z

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1647

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

squashed commits
if necessary:
- includes documentation
- adds unit tests

/hold

linux-foundation-easycla · 2023-09-27T15:42:35Z

The committers listed above are authorized under a signed CLA.

✅ login: alexandrevilain / name: Alexandre Vilain (f444006)

netlify · 2023-09-27T15:42:37Z

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name	Link
🔨 Latest commit	`f444006`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/6536720f833a8f0008a2bbdc
😎 Deploy Preview	https://deploy-preview-1688--kubernetes-sigs-cluster-api-openstack.netlify.app/print
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

k8s-ci-robot · 2023-09-27T15:42:40Z

Hi @alexandrevilain. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

lentzi90 · 2023-09-29T07:50:49Z

/ok-to-test

alexandrevilain · 2023-09-29T08:06:32Z

/retest

alexandrevilain · 2023-09-29T08:23:32Z

/retest

mdbooth · 2023-09-29T08:58:20Z

@alexandrevilain If you run make lint-update it normally fixes those things for you automatically.

alexandrevilain · 2023-09-29T09:11:12Z

Oh thanks @mdbooth!

/retest

alexandrevilain · 2023-10-02T11:59:37Z

I think it's ready for review.
Tested on my side, after the controller reboots, it makes somes API requests to keystone and then stop doing such request for 12 hours.

lentzi90 · 2023-10-03T06:28:06Z

main.go

+	if scopeCacheMaxSize <= 0 {
+		err := errors.New("--scope-cache-max-size should be > 0")
+		setupLog.Error(err, "unable to start manager")
+		os.Exit(1)
+	}


What do you think about allowing 0 cache size as a way to disable caching?
I'm not sure if that is something we need to support but it is often beneficial to be able to opt-out of new features

Good idea!
Another benefit we can have is to debug without cache if something is going wrong

Updated, setting the flag to --scope-cache-max-size=0 disable the cache.

lentzi90

Looks good!
/lgtm

lentzi90 · 2023-10-04T07:51:22Z

/test pull-cluster-api-provider-openstack-e2e-full-test

alexandrevilain · 2023-10-13T07:33:03Z

/remove-hold

lentzi90 · 2023-10-13T07:38:46Z

/cc @mdbooth

mdbooth

I'll try to get to this properly on Monday.

seanschneeweiss

That is a great addition... We faced problems with Keystone as well, potentially related to too many auth requests, which is still being investigated at this point.

pkg/scope/scope.go

pkg/scope/provider.go

Signed-off-by: alexandre.vilain <[email protected]>

seanschneeweiss

/lgtm

lentzi90 · 2023-10-25T06:20:28Z

Any more comments @mdbooth ? Otherwise I think we can take this in 🙂

EmilienM

/lgtm

lentzi90 · 2023-10-27T06:59:19Z

/hold cancel

lentzi90 · 2023-10-27T07:00:41Z

/approve

k8s-ci-robot · 2023-10-27T07:00:47Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexandrevilain, EmilienM, lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [lentzi90]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Sep 27, 2023

k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 27, 2023

k8s-ci-robot requested review from lentzi90 and mdbooth September 27, 2023 15:42

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 27, 2023

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 29, 2023

alexandrevilain force-pushed the feat/add-provider-scope-cache branch from 18053d1 to 73a7f8e Compare September 29, 2023 08:06

alexandrevilain force-pushed the feat/add-provider-scope-cache branch from 73a7f8e to da18fbd Compare September 29, 2023 08:23

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 29, 2023

alexandrevilain force-pushed the feat/add-provider-scope-cache branch from da18fbd to 2ce485a Compare September 29, 2023 09:10

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 29, 2023

alexandrevilain marked this pull request as ready for review October 2, 2023 11:58

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 2, 2023

k8s-ci-robot requested a review from dulek October 2, 2023 11:58

lentzi90 reviewed Oct 3, 2023

View reviewed changes

alexandrevilain force-pushed the feat/add-provider-scope-cache branch from 2ce485a to 7200107 Compare October 4, 2023 07:19

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 4, 2023

lentzi90 reviewed Oct 4, 2023

View reviewed changes

k8s-ci-robot assigned lentzi90 Oct 4, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 4, 2023

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 13, 2023

mdbooth reviewed Oct 13, 2023

View reviewed changes

seanschneeweiss reviewed Oct 20, 2023

View reviewed changes

pkg/scope/scope.go Outdated Show resolved Hide resolved

pkg/scope/provider.go Outdated Show resolved Hide resolved

pkg/scope/provider.go Show resolved Hide resolved

pkg/scope/provider.go Outdated Show resolved Hide resolved

pkg/scope/provider.go Outdated Show resolved Hide resolved

Add cache on provider scope

f444006

Signed-off-by: alexandre.vilain <[email protected]>

alexandrevilain force-pushed the feat/add-provider-scope-cache branch from 7200107 to f444006 Compare October 23, 2023 13:15

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 23, 2023

seanschneeweiss reviewed Oct 24, 2023

View reviewed changes

k8s-ci-robot assigned seanschneeweiss Oct 24, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 24, 2023

EmilienM approved these changes Oct 25, 2023

View reviewed changes

k8s-ci-robot assigned EmilienM Oct 25, 2023

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2023

k8s-ci-robot merged commit f28da18 into kubernetes-sigs:main Oct 27, 2023

EmilienM mentioned this pull request Jan 24, 2024

controller/openstackcluster: reconcileID is re-used 1000+ times #1840

Closed

✨ Add cache on provider scope #1688

✨ Add cache on provider scope #1688

Uh oh!

Conversation

alexandrevilain commented Sep 27, 2023

Uh oh!

linux-foundation-easycla bot commented Sep 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Sep 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Uh oh!

k8s-ci-robot commented Sep 27, 2023

Uh oh!

lentzi90 commented Sep 29, 2023

Uh oh!

alexandrevilain commented Sep 29, 2023

Uh oh!

alexandrevilain commented Sep 29, 2023

Uh oh!

mdbooth commented Sep 29, 2023

Uh oh!

alexandrevilain commented Sep 29, 2023

Uh oh!

alexandrevilain commented Oct 2, 2023

Uh oh!

lentzi90 Oct 3, 2023

Choose a reason for hiding this comment

Uh oh!

alexandrevilain Oct 3, 2023

Choose a reason for hiding this comment

Uh oh!

alexandrevilain Oct 4, 2023

Choose a reason for hiding this comment

Uh oh!

lentzi90 left a comment

Choose a reason for hiding this comment

Uh oh!

lentzi90 commented Oct 4, 2023

Uh oh!

alexandrevilain commented Oct 13, 2023

Uh oh!

lentzi90 commented Oct 13, 2023

Uh oh!

mdbooth left a comment

Choose a reason for hiding this comment

Uh oh!

seanschneeweiss left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

seanschneeweiss left a comment

Choose a reason for hiding this comment

Uh oh!

lentzi90 commented Oct 25, 2023

Uh oh!

EmilienM left a comment

Choose a reason for hiding this comment

Uh oh!

lentzi90 commented Oct 27, 2023

Uh oh!

lentzi90 commented Oct 27, 2023

Uh oh!

k8s-ci-robot commented Oct 27, 2023

Uh oh!

Uh oh!

linux-foundation-easycla bot commented Sep 27, 2023 •

edited

Loading

netlify bot commented Sep 27, 2023 •

edited

Loading