🌱 Simplify types of Instance.SecurityGroup and Instance.Networks #1625
Conversation
These both have a type of pointer to slice, which is: * Redundant in Go * Is marshalled identically in the CRD To verify the latter, note that there are no changes to the CRD despite the type change. Also note that the values are unused. The reason for fixing these types is that Semantic.DeepEqual can't compare them correctly so they break the fuzzer tests.
k8s-ci-robot
added
the
do-not-merge/hold
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mdbooth The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/lgtm |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
um.. why the PR hold for CLA ? guess something wrong with github pipeline check now? |
|
/easycla |
k8s-ci-robot
added
the
cncf-cla: yes
I noticed this too and asked about it in Slack: https://kubernetes.slack.com/archives/C1TU9EB9S/p1690819437052009 TL;DR probably a blip, fixed in exactly the way you fixed it 😀 Thanks! |
These both have a type of pointer to slice, which is:
To verify the latter, note that there are no changes to the CRD despite the type change.
Also note that the values are unused.
The reason for fixing these types is that Semantic.DeepEqual can't compare them correctly so they break the fuzzer tests.
/hold