-
Notifications
You must be signed in to change notification settings - Fork 280
Restore APIServerLoadBalancer.Provider on up-conversion #1517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mdbooth The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ching-kuo @dulek My apologies, I missed this in review of #1501. In prior api versions we effectively added an exception to the fuzzer tests for values which were added or removed, but as we're now using CAPI's 'previous version' annotation we can now manually restore these values and we don't need this any more. Incidentally, we might eventually consider retrofitting this to v1alpha5, but it's not worth adding to prior versions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold cancel |
From v1alpha6 onwards we have the facility to losslessly preserve values during conversion which were added or removed in the new version, so we should never require the FuzzerFuncs argument to the fuzzer conversion tests.
/hold