Skip to content

Conversation

mdbooth
Copy link
Contributor

@mdbooth mdbooth commented Mar 28, 2023

From v1alpha6 onwards we have the facility to losslessly preserve values during conversion which were added or removed in the new version, so we should never require the FuzzerFuncs argument to the fuzzer conversion tests.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 28, 2023
@netlify
Copy link

netlify bot commented Mar 28, 2023

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 1534cdb
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/6422c8e4270a8100083fd016
😎 Deploy Preview https://deploy-preview-1517--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 28, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 28, 2023
@mdbooth
Copy link
Contributor Author

mdbooth commented Mar 28, 2023

@ching-kuo @dulek My apologies, I missed this in review of #1501. In prior api versions we effectively added an exception to the fuzzer tests for values which were added or removed, but as we're now using CAPI's 'previous version' annotation we can now manually restore these values and we don't need this any more.

Incidentally, we might eventually consider retrofitting this to v1alpha5, but it's not worth adding to prior versions.

/cc @lentzi90 @tobiasgiese

Copy link
Contributor

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 28, 2023
@mdbooth
Copy link
Contributor Author

mdbooth commented Mar 28, 2023

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 28, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8b57e0a into kubernetes-sigs:main Mar 28, 2023
@mdbooth mdbooth deleted the nofuzzerfuncs branch March 28, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants