🐛 Switch to "4" instead of "ipip" for rules

[mnaser]

What this PR does / why we need it:
This PR fixes a regression where we started using ipip instead of 4 for the security groups. Inside Linux, the protocol ipip maps to protocol number 94 which is what Neutron uses when you use that, which meant that all Calico IPIP connectivity stopped working with this change

root@abb2f5652d8f:/# egrep '^(ipencap|ipip)' /etc/protocols
ipencap	4	IP-ENCAP	# IP encapsulated in IP (officially ``IP'')
ipip	94	IPIP		# IP-within-IP Encapsulation Protocol

Unfortunately, the Neutron API does not accept ipencap therefore we should go back to putting the digit to make things work again.

Related: #1290

Which issue(s) this PR fixes:
Fixes #1484

Special notes for your reviewer:

The generated iptables rules look like this:

    0     0 RETURN     94    --  *      *       0.0.0.0/0            0.0.0.0/0            match-set NIPv4c7df0104-3ffe-47fd-972b- src
    0     0 RETURN     94    --  *      *       0.0.0.0/0            0.0.0.0/0            match-set NIPv4c845a9c7-aafa-46b2-95ed- src

Those don't end up sending any traffic through.

1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

• squashed commits
• if necessary:
  • includes documentation
  • adds unit tests

/hold

[netlify]

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name	Link
🔨 Latest commit	f910e87
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/63f77db849511e0008819394
😎 Deploy Preview	https://deploy-preview-1489--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[k8s-ci-robot]

Hi @mnaser. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mdbooth]

/ok-to-test

[jichenjc]

/lgtm
/approve
/hold cancel

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc, mnaser

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jichenjc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[lentzi90]

/cherry-pick release-0.7

[k8s-infra-cherrypick-robot]

@lentzi90: new pull request created: #1493

In response to this:

/cherry-pick release-0.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.