Skip to content

Conversation

@Ganiredi
Copy link
Contributor

@Ganiredi Ganiredi commented Sep 3, 2025

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 3, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @Ganiredi. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 3, 2025
@bryantbiggs
Copy link
Member

shouldn't these vulnerability checks be resolved before a release is cut? https://github.com/kubernetes-sigs/aws-iam-authenticator/actions/runs/17396548209/job/49379655850?pr=910

@bryantbiggs
Copy link
Member

bryantbiggs commented Sep 3, 2025

This should report the same failures once triggered https://github.com/kubernetes-sigs/aws-iam-authenticator/actions/runs/17437647435?pr=911

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 3, 2025
@bryantbiggs
Copy link
Member

should be fixed in #912

@Ganiredi
Copy link
Contributor Author

Ganiredi commented Sep 3, 2025

Thanks for looking into this @bryantbiggs and for raising #912

@bryantbiggs
Copy link
Member

looks like #912 is all green - once that lands, we should be good to cut a clean release

@bryantbiggs
Copy link
Member

/lgtm

cc @kmala for approval

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 3, 2025
@kmala
Copy link
Contributor

kmala commented Sep 4, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ganiredi, kmala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2025
@k8s-ci-robot k8s-ci-robot merged commit 922f6b2 into kubernetes-sigs:master Sep 4, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants