-
Notifications
You must be signed in to change notification settings - Fork 291
Authentication with Kerberos credentials #999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Authentication with Kerberos credentials #999
Conversation
…eros authentication
this will allow the authentication password to be passed to `kinit`
…edentials are provided
- change base image to `debian:stable-slim` justification: services cannot be started due to missing file `/lib/lsb/init-functions` - invoke a script (`entry.sh`) that then invokes `/nfsplugin` with any passed args. justification: this is so we can start necessary services (`rpcbind` and `nfs-common`) if and only if we're in the controller pod. - set `entry.sh` as the entrypoint
…he first argument this is to tell the script that we're running as a controller, so the necessary services can be started
- apply the kerberos nfs server deployment with `kubectl` - add a `krb-pwd` key to the `mount-options` secret, which will be used to authenticate with the share in tests
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: GamerGirlandCo The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Welcome @GamerGirlandCo! |
|
Hi @GamerGirlandCo. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
andyzhangx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
|
/retest |
c3f3728 to
2f68b58
Compare
|
/retest |
allows an end user to specify a secret which contains contents of a kerberos 5 configuration file that specifies how to connect to one or more realms
2f68b58 to
250ff6d
Compare
|
/retest |
ensure that `nfs-common` daemons have been started properly
fix reference to secret that doesn't exist in CI environment
add more detailed error logging during kerberos auth phase
|
/test pull-csi-driver-nfs-e2e-capz |
open/expose tcp port 111
08357f1 to
f29f24c
Compare
|
/retest-required |
a5793cc to
2a4e0cd
Compare
629095f to
d615d7f
Compare
078e93a to
91a8cd4
Compare
use ubuntu nfs-krb image instead of alpine to maybe fix timeouts
91a8cd4 to
13221c1
Compare
switch back to alpine nfs-krb image, open TCP port 111
|
@GamerGirlandCo: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR implements authentication with a kerberos principal and password when mounting NFS shares.
Which issue(s) this PR fixes:
Fixes #525
Special notes for your reviewer:
debian:stable-slimJustification: services cannot be started due to a missing file
/lib/lsb/init-functionsentry.sh)The script is created in the Dockerfile inline, and you can review it here
Justification: this is so we can start necessary services (
rpcbindandnfs-common) if and only if we're in the controller pod. Otherwise, thenfspluginbinary is invoked with the exact same arguments the pod'snfscontainer was started with.Does this PR introduce a user-facing change?: