cnt cannot be used as a standard to perform logout

[zhucan]

csi-driver-iscsi/pkg/iscsi/iscsi_util.go

Line 83 in 12d5f01

_, cnt, err := mount.GetDeviceNameFromMount(c.mounter, targetPath)

If there is only one worker node, when the pod rebuilding, the NodePublishVolume will be called first, and then the NodeUnpublishVolume will be called after the NodePublishVolume. Because of every times the pod rebuilding the targetPath is different, We cant't judge whether the volume is used, when the NodeUnpublishVolume is called, the cnt is always 1, it will logout, the connection between volume and pod will lost.

@saad-ali

[msau42]

/assign @j-griffith @bswartz

[j-griffith]

I'll have to take a closer look at this again, I'm not sure why the target-path should be different each time here, and if it is; it's unclear to me how one would determine duplicate device mounts?

[zhucan]

If the kind of the pod is deployment, when the pod rebuilding the target-path is different, because of the uuid of the pod is different. The examples of the target-path: "/var/lib/kubelet/pods/e343ee06-1b21-4037-a509-9224df45fbd0/volumes/kubernetes.io~csi/pvc-78f9fa64-e0a5-4253-8e0a-e11dc9fe362f/mount"

It's possible for that one device corresponds to two targetPath when the deployment rebuilding on the same node.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.