Skip to content

Conversation

@yue9944882
Copy link
Member

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 16, 2021
@brendandburns
Copy link
Contributor

Are these in the 14.0.0 release? If not we should probably cut a 14.0.1

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 16, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, yue9944882

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [brendandburns,yue9944882]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8b29528 into kubernetes-client:master Nov 16, 2021
@yue9944882
Copy link
Member Author

Are these in the 14.0.0 release? If not we should probably cut a 14.0.1

@brendandburns the module fluent-gen is never published, so i guess it's fine. or we can separate the versioning of this module from the parent starting from a v1.0.0 b/c it's irrelevant to the parent's versioning, wdyt?

@brendandburns
Copy link
Contributor

Sorry, I wasn't clear: what I was wondering was: "did you regenerate the fluent bindings for the 14.0.0 release?"

And then I realized that I actually had regenerated them in #1936, so I was just confused.

Apologies for the noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants