Skip to content

Conversation

andreyvelich
Copy link
Member

@andreyvelich andreyvelich commented Sep 30, 2021

Blocked by: kubeflow/katib#1688.
Fixes: kubeflow/katib#1689.

We added example for MXJob in Katib recently.

@andreyvelich andreyvelich changed the title [WIP] Katib: Add support for MXJob Katib: Add support for MXJob Oct 8, 2021
@andreyvelich
Copy link
Member Author

This PR is ready.
/assign @gaocegege @johnugeorge @tenzen-y

@johnugeorge
Copy link
Member

/lgtm
/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 1d7d7a1 into kubeflow:master Oct 8, 2021
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tenzen-y
Copy link
Member

tenzen-y commented Oct 8, 2021

LGTM

@andreyvelich andreyvelich deleted the issue-1689-katib-mxjob-support branch October 8, 2021 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Documentation] Add MXJob to supported Katib Worker types
5 participants