-
Notifications
You must be signed in to change notification settings - Fork 834
add workqueue and reflect metrics #541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
We met the same problem during the development of v1alpha2. And we choose to copy the code from k8s into our code base. I think maybe we should migrate from glide to dep and use |
|
I think switching to dep can solve our problem. I have already used it in my own project. I think it is a better package management tool. more detail in github.com/golang/dep. |
|
Yeah, I prefer dep, too. I opened an issue for it.#556 |
|
#557 is merged and I think you could use dep to reduce the vendor size. |
I found that our current client-go dependency is a 1.8 cluster and we need to upgrade the dependency to 1.10? |
|
@zjj2wry Is the clientgo 1.10 compatible with Kubernetes 1.8? And why do we need to upgrade it 🤔 |
ee0af75 to
94d477b
Compare
|
Fixes #503 updated, @gaocegege @jlewi |
|
/lgtm if you already run |
yes, i already do it~ |
|
/lgtm Thanks! |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Although only the k8s.io/kubernetes/pkg/util/reflector/prometheus package was used, glide is still dumped into the entire k8s project. and i use
glide get k8s.io/kubernetes/pkg/util/workqueue/prometheus --forcecommand import package. Who has the idea to fix this problem?This change is