Skip to content

Conversation

@zjj2wry
Copy link
Member

@zjj2wry zjj2wry commented Apr 17, 2018

Although only the k8s.io/kubernetes/pkg/util/reflector/prometheus package was used, glide is still dumped into the entire k8s project. and i use glide get k8s.io/kubernetes/pkg/util/workqueue/prometheus --force command import package. Who has the idea to fix this problem?


This change is Reviewable

@gaocegege
Copy link
Member

We met the same problem during the development of v1alpha2. And we choose to copy the code from k8s into our code base.

I think maybe we should migrate from glide to dep and use dep prune to remove useless packages.

@coveralls
Copy link

coveralls commented Apr 17, 2018

Coverage Status

Coverage remained the same at 54.357% when pulling 94d477b on zjj2wry:workqueque_metrics into eebc838 on kubeflow:master.

@zjj2wry
Copy link
Member Author

zjj2wry commented Apr 24, 2018

I think switching to dep can solve our problem. I have already used it in my own project. I think it is a better package management tool. more detail in github.com/golang/dep.
@jlewi @wbuchwalter @gaocegege wdyt?

@gaocegege
Copy link
Member

Yeah, I prefer dep, too. I opened an issue for it.#556

@gaocegege
Copy link
Member

#557 is merged and I think you could use dep to reduce the vendor size.

@zjj2wry
Copy link
Member Author

zjj2wry commented May 3, 2018

#557 is merged and I think you could use dep to reduce the vendor size.

I found that our current client-go dependency is a 1.8 cluster and we need to upgrade the dependency to 1.10?

@gaocegege
Copy link
Member

gaocegege commented May 3, 2018

@zjj2wry Is the clientgo 1.10 compatible with Kubernetes 1.8?

And why do we need to upgrade it 🤔

@zjj2wry zjj2wry force-pushed the workqueque_metrics branch from ee0af75 to 94d477b Compare June 13, 2018 05:50
@zjj2wry zjj2wry changed the title wip: add workqueue and reflect metrics add workqueue and reflect metrics Jun 13, 2018
@zjj2wry
Copy link
Member Author

zjj2wry commented Jun 13, 2018

Fixes #503

updated, @gaocegege @jlewi

@gaocegege
Copy link
Member

/lgtm if you already run dep prune

@zjj2wry
Copy link
Member Author

zjj2wry commented Jun 13, 2018

if you already run dep prune

yes, i already do it~

@gaocegege
Copy link
Member

/lgtm

Thanks!

@gaocegege
Copy link
Member

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ee1709f into kubeflow:master Jun 13, 2018
yph152 pushed a commit to yph152/tf-operator that referenced this pull request Jun 18, 2018
jetmuffin pushed a commit to jetmuffin/tf-operator that referenced this pull request Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants