-
Notifications
You must be signed in to change notification settings - Fork 829
Update README and out-of-date docs #2252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Andrey Velichkevich <[email protected]>
Signed-off-by: Andrey Velichkevich <[email protected]>
Signed-off-by: Andrey Velichkevich <[email protected]>
Pull Request Test Coverage Report for Build 10777559413Details
💛 - Coveralls |
README.md
Outdated
Please refer to the [getting started guide](https://www.kubeflow.org/docs/components/training/overview/#getting-started) | ||
to quickly create your first Training Operator Job using Python SDK. | ||
Please refer to [the getting started guide](https://www.kubeflow.org/docs/components/training/getting-started/#getting-started-with-pytorchjob) | ||
to quickly create your first distributed training job using Python SDK. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to quickly create your first distributed training job using Python SDK. | |
to quickly create your first distributed training job using the Python SDK. |
For a complete reference of the custom resource definitions, please refer to the API Definition. | ||
|
||
- [TensorFlow API Definition](pkg/apis/kubeflow.org/v1/tensorflow_types.go) | ||
- [PyTorch API Definition](pkg/apis/kubeflow.org/v1/pytorch_types.go) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! one small nit
Signed-off-by: Andrey Velichkevich <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: franciscojavierarceo, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks for the review! |
As part of our effort to put all docs on kubeflow.org website, I made the following changes to the README and docs:
release
andproposals
@kubeflow/wg-training-leads do we want to move them to the root as well ?/hold for review
cc @kubeflow/wg-training-leads @franciscojavierarceo @StefanoFioravanzo @hbelmiro Please let me know what do you think.