[SDK] Add UTs for wait_for_job_conditions
#2196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Electronic-Waste
force-pushed
the
test/wait-for-job-conditions
branch
from
2743bab to
f889b9f
Compare
Pull Request Test Coverage Report for Build 10632610394Details
💛 - Coveralls |
15 tasks
There was a problem hiding this comment.
Sorry for the late reply @Electronic-Waste!
Please can you rebase your PR so we can review it ?
Signed-off-by: Electronic-Waste <[email protected]>
Signed-off-by: Electronic-Waste <[email protected]>
Signed-off-by: Electronic-Waste <[email protected]>
Signed-off-by: Electronic-Waste <[email protected]>
Electronic-Waste
force-pushed
the
test/wait-for-job-conditions
branch
from
f889b9f to
53c8e83
Compare
|
@andreyvelich Sure! I've rebased the branch to master. |
Signed-off-by: Electronic-Waste <[email protected]>
There was a problem hiding this comment.
Thanks for this @Electronic-Waste!
/assign @droctothorpe @YosiElias @kubeflow/wg-training-leads
| yield client | ||
|
|
||
|
|
||
| @pytest.fixture |
There was a problem hiding this comment.
Do you need separate fixture just for wait_for_job_condition or we can re-use Training client like for other tests ?
There was a problem hiding this comment.
I separate fixture for wait_for_job_condition because it needs to mock function get_job. I'm not sure whether it will affect other UTs but I can have a try:)
| test_data_wait_for_job_conditions = [ | ||
| ( | ||
| "timeout waiting for succeeded condition", | ||
| {"name": TEST_NAME, "namespace": "timeout", "wait_timeout": 0}, |
There was a problem hiding this comment.
There was a problem hiding this comment.
Okay, I'll replace that.
Signed-off-by: Electronic-Waste <[email protected]>
|
Thanks for the update @Electronic-Waste! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6 tasks
szaher
pushed a commit
to szaher/sdk
that referenced
this pull request
Jun 4, 2025
* test(sdk): add unit test for wait_for_job_conditions. Signed-off-by: Electronic-Waste <[email protected]> * test(sdk): fix lint error. Signed-off-by: Electronic-Waste <[email protected]> * test(sdk): add patch for load_kube_config. Signed-off-by: Electronic-Waste <[email protected]> * test(trial): fix lint error with black. Signed-off-by: Electronic-Waste <[email protected]> * test(trial): add package dependency. Signed-off-by: Electronic-Waste <[email protected]> * test(sdk): reuse exisiting fixture. Signed-off-by: Electronic-Waste <[email protected]> --------- Signed-off-by: Electronic-Waste <[email protected]>
szaher
pushed a commit
to szaher/sdk
that referenced
this pull request
Jun 4, 2025
* test(sdk): add unit test for wait_for_job_conditions. Signed-off-by: Electronic-Waste <[email protected]> * test(sdk): fix lint error. Signed-off-by: Electronic-Waste <[email protected]> * test(sdk): add patch for load_kube_config. Signed-off-by: Electronic-Waste <[email protected]> * test(trial): fix lint error with black. Signed-off-by: Electronic-Waste <[email protected]> * test(trial): add package dependency. Signed-off-by: Electronic-Waste <[email protected]> * test(sdk): reuse exisiting fixture. Signed-off-by: Electronic-Waste <[email protected]> --------- Signed-off-by: Electronic-Waste <[email protected]>
szaher
pushed a commit
to szaher/sdk
that referenced
this pull request
Jun 4, 2025
* test(sdk): add unit test for wait_for_job_conditions. Signed-off-by: Electronic-Waste <[email protected]> * test(sdk): fix lint error. Signed-off-by: Electronic-Waste <[email protected]> * test(sdk): add patch for load_kube_config. Signed-off-by: Electronic-Waste <[email protected]> * test(trial): fix lint error with black. Signed-off-by: Electronic-Waste <[email protected]> * test(trial): add package dependency. Signed-off-by: Electronic-Waste <[email protected]> * test(sdk): reuse exisiting fixture. Signed-off-by: Electronic-Waste <[email protected]> --------- Signed-off-by: Electronic-Waste <[email protected]>
szaher
pushed a commit
to szaher/sdk
that referenced
this pull request
Jun 5, 2025
* test(sdk): add unit test for wait_for_job_conditions. Signed-off-by: Electronic-Waste <[email protected]> * test(sdk): fix lint error. Signed-off-by: Electronic-Waste <[email protected]> * test(sdk): add patch for load_kube_config. Signed-off-by: Electronic-Waste <[email protected]> * test(trial): fix lint error with black. Signed-off-by: Electronic-Waste <[email protected]> * test(trial): add package dependency. Signed-off-by: Electronic-Waste <[email protected]> * test(sdk): reuse exisiting fixture. Signed-off-by: Electronic-Waste <[email protected]> --------- Signed-off-by: Electronic-Waste <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
I add some UTs for function
wait_for_job_conditionsin the Python SDKWhich issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...format, will close the issue(s) when PR gets merged):Ref #2161
Checklist: