Skip to content

Conversation

yuzisun
Copy link
Member

@yuzisun yuzisun commented Dec 31, 2021

Which issue is resolved by this Pull Request:
Resolves #

Description of your changes:
Looks most of kubeflow projects like training-operator, katib and kserve have migrated to go 1.17.3, so make sense to update in e2e testing worker image as well.

With go 1.14 we are getting errors like following:

/root/go/pkg/mod/k8s.io/[email protected]/plugin/pkg/client/auth/exec/metrics.go:21:2: package io/fs is not in GOROOT (/usr/local/go/src/io/fs)

Checklist:

If PR related to Optional-Test-Infra,

  • Changes need to be generated to aws/GitOps folder:
    1. cd aws
    2. make optional-generate
    3. make optional-test

@yuzisun
Copy link
Member Author

yuzisun commented Jan 1, 2022

/assign @theofpa

@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in one week if no further activity occurs. Thank you for your contributions.

@stale
Copy link

stale bot commented Apr 27, 2022

This issue has been closed due to inactivity.

@stale stale bot closed this Apr 27, 2022
@tenzen-y
Copy link
Member

/reopen
Hi @yuzisun
I also encountered this problem in the Katib project. So I think we should upgrade Go version in CI.

go: downloading cloud.google.com/go v0.81.0
go: downloading gopkg.in/yaml.v3 v3.0.0-20210107192922-496545a6307b
go: downloading golang.org/x/text v0.3.6
../../../../pkg/mod/k8s.io/[email protected]/plugin/pkg/client/auth/exec/metrics.go:21:2: package io/fs is not in GOROOT (/usr/local/go/src/io/fs)

https://argo.kubeflow-testing.com/workflows/kubeflow-test-infra/kubeflow-katib-presubmit-e2e-v1beta1-1861-d2f2d60-1248-25a9?tab=workflow&nodeId=kubeflow-katib-presubmit-e2e-v1beta1-1861-d2f2d60-1248-25a9-2154460364&sidePanel=logs%3Akubeflow-katib-presubmit-e2e-v1beta1-1861-d2f2d60-1248-25a9-2154460364%3Amain

@google-oss-prow
Copy link

@tenzen-y: Reopened this PR.

In response to this:

/reopen
Hi @yuzisun
I also encountered this problem in the Katib project. So I think we should upgrade Go version in CI.

go: downloading cloud.google.com/go v0.81.0
go: downloading gopkg.in/yaml.v3 v3.0.0-20210107192922-496545a6307b
go: downloading golang.org/x/text v0.3.6
../../../../pkg/mod/k8s.io/[email protected]/plugin/pkg/client/auth/exec/metrics.go:21:2: package io/fs is not in GOROOT (/usr/local/go/src/io/fs)

https://argo.kubeflow-testing.com/workflows/kubeflow-test-infra/kubeflow-katib-presubmit-e2e-v1beta1-1861-d2f2d60-1248-25a9?tab=workflow&nodeId=kubeflow-katib-presubmit-e2e-v1beta1-1861-d2f2d60-1248-25a9-2154460364&sidePanel=logs%3Akubeflow-katib-presubmit-e2e-v1beta1-1861-d2f2d60-1248-25a9-2154460364%3Amain

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-prow google-oss-prow bot reopened this May 21, 2022
@tenzen-y
Copy link
Member

/assign @chensun
/assign @zijianjoy

@zijianjoy
Copy link
Contributor

/lgtm
/approve

@stale stale bot removed the lifecycle/stale label May 21, 2022
@google-oss-prow google-oss-prow bot added the lgtm label May 21, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yuzisun, zijianjoy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants