Skip to content

Conversation

@nabuskey
Copy link
Contributor

Purpose of this PR

Looks like unit tests were commented out as part of the migration effort. This PR adds it back with some fixes.

Proposed changes:

  • Add unit tests for monitoring config

Change Category

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that could affect existing functionality)
  • Documentation update

Rationale

Checklist

  • I have conducted a self-review of my own code.
  • I have updated documentation accordingly.
  • I have added tests that prove my changes are effective or that my feature works.
  • Existing unit tests pass locally with my changes.

Additional Notes

Signed-off-by: Manabu McCloskey <[email protected]>
Signed-off-by: Manabu McCloskey <[email protected]>
@google-oss-prow google-oss-prow bot added size/XL and removed size/L labels May 16, 2025
@ChenYi015
Copy link
Member

Thanks for fixing the unit tests.
/approve

@google-oss-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChenYi015

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 851668f into kubeflow:master May 17, 2025
15 checks passed
@nabuskey nabuskey deleted the unit-test-monitring-conf branch May 17, 2025 18:27
@ChenYi015 ChenYi015 mentioned this pull request May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants