Skip to content

Conversation

tarekabouzeid
Copy link
Member

@tarekabouzeid tarekabouzeid commented May 10, 2025

Purpose of this PR

Proposed changes:

  • Adding securityContext to spark examples

Change Category

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that could affect existing functionality)
  • Documentation update

Rationale

Checklist

  • I have conducted a self-review of my own code.
  • I have updated documentation accordingly.
  • I have added tests that prove my changes are effective or that my feature works.
  • Existing unit tests pass locally with my changes.

Additional Notes

Refer to discussions here #2401
CC @juliusvonkohout

Copy link
Member

@ChenYi015 ChenYi015 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just two tiny format issues:

  • Do not use indentation in array.
  • Add a new line at the end of file.

Signed-off-by: Tarek Abouzeid <[email protected]>
@tarekabouzeid
Copy link
Member Author

LGTM. Just two tiny format issues:

  • Do not use indentation in array.
  • Add a new line at the end of file.

Thanks @ChenYi015 for review, I have updated the PR accordingly.

@ChenYi015
Copy link
Member

/lgtm
/approve

Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChenYi015

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 0cb98f7 into kubeflow:master May 13, 2025
15 checks passed
@ChenYi015 ChenYi015 mentioned this pull request May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants