Skip to content

Conversation

bjmask
Copy link
Contributor

@bjmask bjmask commented Jun 29, 2021

Added username and password support for basic auth proxies.

basic auth usage:

from urrllib import make_headers

basic_auth_headers = make_headers(basic_auth=f"{proxy_username}:{proxy_password}")

client = kfp.Client(HOST_NAME, proxy=YOUR_PROXY_HOST, proxy_headers=basic_auth_headers)

kerberos usage

from requests_kerberos import HTTPKerberosAuth

kerb_auth = HTTPKerberosAuth(mutual_authentication="MUTUAL", force_preemptive=True)
auth_header = kerb_auth.generate_request_header(None, HOSTNAME, True)
client = kfp.Client(HOST_NAME, proxy=YOUR_PROXY_HOST, proxy_headers={"Proxy-Authorization": auth_header})

@google-oss-robot
Copy link

Hi @andres-de-castro. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-cla
Copy link

google-cla bot commented Jun 29, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Jun 29, 2021
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign ji-yaqi after the PR has been reviewed.
You can assign the PR to them by writing /assign @ji-yaqi in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-cla
Copy link

google-cla bot commented Jun 29, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@bjmask
Copy link
Contributor Author

bjmask commented Jun 29, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Jun 29, 2021
@chensun
Copy link
Member

chensun commented Jun 29, 2021

/ok-to-test

andresdec added 2 commits July 1, 2021 09:49
…:andres-de-castro/pipelines into add-proxy-basic-auth-to-kfp-pipeline-sdk

* 'add-proxy-basic-auth-to-kfp-pipeline-sdk' of github.com:andres-de-castro/pipelines:
  Update sync.py
@bjmask bjmask changed the title feat(sdk): add proxy username and password support to kfp client to support basic auth'd proxies feat(sdk): Add interface to support basic auth and kerberos SPNEGO reverse proxy Jul 1, 2021
@google-oss-robot
Copy link

@andres-de-castro: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-pipelines-samples-v2 8f61d2e link /test kubeflow-pipelines-samples-v2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


from kfp._auth import get_auth_token, get_gcp_access_token

from urllib3 import make_headers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems not used?

@Bobgy
Copy link
Contributor

Bobgy commented Jul 5, 2021

@andres-de-castro we are moving towards building an interface for auth in #5287.

Can we improve that interface if it doesn't allow your use case for now? This will make sure we can organize auth methods in a maintainable and pluggable way.

@stale
Copy link

stale bot commented Mar 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Mar 2, 2022
@rimolive
Copy link
Member

Closing this PR. No activity for more than a year.

/close

@stale stale bot removed the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Mar 24, 2024
@google-oss-prow google-oss-prow bot closed this Mar 24, 2024
Copy link

@rimolive: Closed this PR.

In response to this:

Closing this PR. No activity for more than a year.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants