-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat(sdk): Add interface to support basic auth and kerberos SPNEGO reverse proxy #5945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk): Add interface to support basic auth and kerberos SPNEGO reverse proxy #5945
Conversation
Hi @andres-de-castro. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
/ok-to-test |
…:andres-de-castro/pipelines into add-proxy-basic-auth-to-kfp-pipeline-sdk * 'add-proxy-basic-auth-to-kfp-pipeline-sdk' of github.com:andres-de-castro/pipelines: Update sync.py
@andres-de-castro: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
||
from kfp._auth import get_auth_token, get_gcp_access_token | ||
|
||
from urllib3 import make_headers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems not used?
@andres-de-castro we are moving towards building an interface for auth in #5287. Can we improve that interface if it doesn't allow your use case for now? This will make sure we can organize auth methods in a maintainable and pluggable way. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Closing this PR. No activity for more than a year. /close |
@rimolive: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Added username and password support for basic auth proxies.
basic auth usage:
from urrllib import make_headers
basic_auth_headers = make_headers(basic_auth=f"{proxy_username}:{proxy_password}")
client = kfp.Client(HOST_NAME, proxy=YOUR_PROXY_HOST, proxy_headers=basic_auth_headers)
kerberos usage
from requests_kerberos import HTTPKerberosAuth
kerb_auth = HTTPKerberosAuth(mutual_authentication="MUTUAL", force_preemptive=True)
auth_header = kerb_auth.generate_request_header(None, HOSTNAME, True)
client = kfp.Client(HOST_NAME, proxy=YOUR_PROXY_HOST, proxy_headers={"Proxy-Authorization": auth_header})