-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix(components): Refactor Kubeflow E2E mnist example #5433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(components): Refactor Kubeflow E2E mnist example #5433
Conversation
@andreyvelich: GitHub didn't allow me to assign the following users: chinhuang007. Note that only kubeflow members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Thank you for these efforts! |
I'll report back when there's progress on the KFP PR |
Thank you Yuan! Added an item to use this E2E example to validate Kubeflow deployment in https://github.com/kubeflow/pipelines/projects/12 |
Hello @andreyvelich , I have validated the E2E mnist example using this PR, but I encountered this issue but couldn't explain why, would you like to help on debugging? GoogleCloudPlatform/kubeflow-distribution#271 |
Hi @Bobgy @zijianjoy, I was able to run this example in Multi-User mode using the latest KFP SDK version 1.6.5. If you are fine with this example, I think we can finally merge it. |
Thank you @andreyvelich for the change! I redeployed a cluster to validate the E2E workflow, I encountered the following issue in the first step: How to look closer for the log to debug further? |
Thank you for the testing @zijianjoy. |
/lgtm Debugged with Andrey offline, I am able to run the E2E example:
Approving this PR, thank you so much Andrey again for helping to refresh the E2E workflow example! |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: zijianjoy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of your changes:
Fixes: #5306.
Blocked by: #5287, #5676
I refactored E2E MNIST Kubeflow example. I named it
kubeflow-e2e-mnist
to be more precise and I added OWNERS file.Please let me know if I need to add someone else in the OWNERS.
For Katib, TFJob and KFServing I am using the upstream launchers to run the KFP tasks.
This example uses namespaced Pipeline to run it from the Kubeflow Notebook and we should merge: #5287 to update the KFP SDK.
Please take a look.
/assign @Bobgy @zijianjoy @Tomcli @chinhuang007
/cc @gaocegege @johnugeorge @elikatsis
Checklist:
Do you want this pull request (PR) cherry-picked into the current release branch?
Learn more about cherry-picking updates into the release branch.