Skip to content

Conversation

dhellmann
Copy link
Contributor

Description of your changes:

The source distribution produced does not include all of the files
needed to rebuild the wheel. This change adds a MANIFEST.in file to
cause the requirements.txt and requirements-dev.txt files to be included
so when the setup.py tries to read them they are present.

Checklist:

The source distribution produced does not include all of the files
needed to rebuild the wheel. This change adds a MANIFEST.in file to
cause the requirements.txt and requirements-dev.txt files to be included
so when the setup.py tries to read them they are present.

Signed-off-by: Doug Hellmann <[email protected]>
Copy link

Hi @dhellmann. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

github-actions bot commented Oct 8, 2025

🚫 This command cannot be processed. Only organization members or owners can use the commands.

@dhellmann
Copy link
Contributor Author

@HumairAK it looks like you've modified the python packaging code most recently, could you take a look at this please? We're trying to rebuild the package from source for a downstream distribution and the missing files mean we can't build from the sdist. Thanks!

@HumairAK
Copy link
Collaborator

HumairAK commented Oct 9, 2025

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit de73b6f into kubeflow:master Oct 9, 2025
16 checks passed
HumairAK pushed a commit to HumairAK/data-science-pipelines that referenced this pull request Oct 9, 2025
The source distribution produced does not include all of the files
needed to rebuild the wheel. This change adds a MANIFEST.in file to
cause the requirements.txt and requirements-dev.txt files to be included
so when the setup.py tries to read them they are present.

Signed-off-by: Doug Hellmann <[email protected]>
Signed-off-by: Humair Khan <[email protected]>

(cherry picked from commit de73b6f)
google-oss-prow bot pushed a commit that referenced this pull request Oct 9, 2025
* fix: include requirements files in python sdist (#12330)

The source distribution produced does not include all of the files
needed to rebuild the wheel. This change adds a MANIFEST.in file to
cause the requirements.txt and requirements-dev.txt files to be included
so when the setup.py tries to read them they are present.

Signed-off-by: Doug Hellmann <[email protected]>
Signed-off-by: Humair Khan <[email protected]>

(cherry picked from commit de73b6f)

* chore: release 2.14.5

automate requirements updates

Signed-off-by: Humair Khan <[email protected]>

---------

Signed-off-by: Humair Khan <[email protected]>
Co-authored-by: Doug Hellmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants