-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix: include requirements files in python sdist #12330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: include requirements files in python sdist #12330
Conversation
The source distribution produced does not include all of the files needed to rebuild the wheel. This change adds a MANIFEST.in file to cause the requirements.txt and requirements-dev.txt files to be included so when the setup.py tries to read them they are present. Signed-off-by: Doug Hellmann <[email protected]>
|
Hi @dhellmann. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
🚫 This command cannot be processed. Only organization members or owners can use the commands. |
|
@HumairAK it looks like you've modified the python packaging code most recently, could you take a look at this please? We're trying to rebuild the package from source for a downstream distribution and the missing files mean we can't build from the sdist. Thanks! |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HumairAK The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The source distribution produced does not include all of the files needed to rebuild the wheel. This change adds a MANIFEST.in file to cause the requirements.txt and requirements-dev.txt files to be included so when the setup.py tries to read them they are present. Signed-off-by: Doug Hellmann <[email protected]> Signed-off-by: Humair Khan <[email protected]> (cherry picked from commit de73b6f)
* fix: include requirements files in python sdist (#12330) The source distribution produced does not include all of the files needed to rebuild the wheel. This change adds a MANIFEST.in file to cause the requirements.txt and requirements-dev.txt files to be included so when the setup.py tries to read them they are present. Signed-off-by: Doug Hellmann <[email protected]> Signed-off-by: Humair Khan <[email protected]> (cherry picked from commit de73b6f) * chore: release 2.14.5 automate requirements updates Signed-off-by: Humair Khan <[email protected]> --------- Signed-off-by: Humair Khan <[email protected]> Co-authored-by: Doug Hellmann <[email protected]>
Description of your changes:
The source distribution produced does not include all of the files
needed to rebuild the wheel. This change adds a MANIFEST.in file to
cause the requirements.txt and requirements-dev.txt files to be included
so when the setup.py tries to read them they are present.
Checklist: