Skip to content

Fix seaweedfs flaky test #12175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 29, 2025
Merged

Fix seaweedfs flaky test #12175

merged 6 commits into from
Aug 29, 2025

Conversation

akagami-harsh
Copy link
Contributor

Description of your changes:

  • added a patch to disable preallocate only for gha

@google-oss-prow Google OSS Prow
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@akagami-harsh akagami-harsh force-pushed the fix-flaky-seaweedfs-test branch 2 times, most recently from 37c9320 to 3b895fe Compare August 23, 2025 15:19
@akagami-harsh
Copy link
Contributor Author

/retest

@akagami-harsh
Copy link
Contributor Author

Hello @HumairAK, the SeaweedFS sample tests have been passing consistently without flakiness. I ran them multiple times in this run. I think we can merge this now, and if the test fails in the future, I’ll look into alternative approaches.

@akagami-harsh akagami-harsh marked this pull request as ready for review August 27, 2025 17:27
@akagami-harsh
Copy link
Contributor Author

/retest

@juliusvonkohout
Copy link
Member

juliusvonkohout commented Aug 28, 2025 •
edited
Loading

Lets please just siable volume preallocation everywhere by default. I do not think that it is worth the headache seaweedfs/seaweedfs#6465
seaweedfs/seaweedfs#6550

should fix #11965 (comment)

@mprahl
Copy link
Collaborator

mprahl commented Aug 28, 2025

/cc @mprahl

@google-oss-prow google-oss-prow bot requested a review from mprahl August 28, 2025 20:24
@google-oss-prow google-oss-prow bot added size/XS and removed size/M labels Aug 28, 2025
@akagami-harsh
disable preallocate for ci
0cfe203 
Signed-off-by: Harshvir Potpose <[email protected]>
@akagami-harsh
test seaweedfs flakyness
4ac293e 
Signed-off-by: Harshvir Potpose <[email protected]>
@akagami-harsh
test
eb02454 
Signed-off-by: Harshvir Potpose <[email protected]>
@akagami-harsh
fix
f4114a3 
Signed-off-by: Harshvir Potpose <[email protected]>
@akagami-harsh
fix
7c9e3c7 
Signed-off-by: Harshvir Potpose <[email protected]>
@akagami-harsh
disable preallocate by default
748a15b 
Signed-off-by: Harshvir Potpose <[email protected]>
@akagami-harsh akagami-harsh force-pushed the fix-flaky-seaweedfs-test branch from d5e8894 to 748a15b Compare August 28, 2025 22:20
@juliusvonkohout
Copy link
Member

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Aug 29, 2025
mprahl
mprahl approved these changes Aug 29, 2025
View reviewed changes
Copy link
Collaborator

@mprahl mprahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mprahl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit f94714e into kubeflow:master Aug 29, 2025
64 checks passed
@akagami-harsh akagami-harsh deleted the fix-flaky-seaweedfs-test branch August 29, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mprahl mprahl mprahl approved these changes

@droctothorpe droctothorpe Awaiting requested review from droctothorpe

@rimolive rimolive Awaiting requested review from rimolive

Assignees

@mprahl mprahl

@juliusvonkohout juliusvonkohout

Labels

approved lgtm size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@akagami-harsh @juliusvonkohout @mprahl