-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[WIP] chore(backend): Storage-layer refactor & Postgres enablement roadmap #12063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[WIP] chore(backend): Storage-layer refactor & Postgres enablement roadmap #12063
Conversation
Hi @kaikaila. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
🚫 This command cannot be processed. Only organization members or owners can use the commands. |
9deb920
to
fb7b159
Compare
d8b6e72
to
73f9149
Compare
73f9149
to
f382b21
Compare
fb05e3c
to
efa6538
Compare
9d160d5
to
49126df
Compare
ce0d462
to
6407e20
Compare
…Client Signed-off-by: kaikaila <[email protected]>
…un/job stores Signed-off-by: kaikaila <[email protected]>
…ckage Signed-off-by: kaikaila <[email protected]>
Signed-off-by: kaikaila <[email protected]>
Signed-off-by: kaikaila <[email protected]>
Signed-off-by: kaikaila <[email protected]>
Signed-off-by: kaikaila <[email protected]>
Signed-off-by: kaikaila <[email protected]>
Signed-off-by: kaikaila <[email protected]>
apiserver launched successfully in kind cluster Signed-off-by: kaikaila <[email protected]>
Signed-off-by: kaikaila <[email protected]>
Signed-off-by: kaikaila <[email protected]>
Signed-off-by: kaikaila <[email protected]>
Signed-off-by: kaikaila <[email protected]>
Signed-off-by: kaikaila <[email protected]>
Signed-off-by: kaikaila <[email protected]>
Signed-off-by: kaikaila <[email protected]>
Signed-off-by: kaikaila <[email protected]>
Signed-off-by: kaikaila <[email protected]>
Signed-off-by: kaikaila <[email protected]>
Signed-off-by: kaikaila <[email protected]>
707691e
to
f9611bf
Compare
Background
Kubeflow Pipelines currently hardcodes MySQL assumptions in its storage layer. To enable PostgreSQL adoption (via pgx driver) and improve long-term maintainability, we need to decouple SQL dialect logic and centralize it into a reusable abstraction.
⸻
Changes
This PR introduces a major refactor of the backend storage layer and related test workflows:
Dialect abstraction
• Introduced DBDialect interface and refactored pipeline/experiment/run/job stores to use it.
• Removed legacy SQLDialect, centralized initialization in InitDBClient.
Storage refactor
• Updated resource_reference, db_status_store, and cache/storage clients to use the new dialect.
• Moved filter logic into dialect package, cleaned up list package.
• Adapted db_fake to support dialect abstraction.
Tests & dependencies
• Updated unit tests across storage, list, and filter packages.
• Updated go.mod dependencies and tidied modules.
• Added PostgreSQL GitHub Actions workflow with kustomize deployment and port-forward.
⸻
CI Status