Skip to content

Conversation

kaikaila
Copy link
Contributor

@kaikaila kaikaila commented Jul 17, 2025

Background

Kubeflow Pipelines currently hardcodes MySQL assumptions in its storage layer. To enable PostgreSQL adoption (via pgx driver) and improve long-term maintainability, we need to decouple SQL dialect logic and centralize it into a reusable abstraction.

Changes

This PR introduces a major refactor of the backend storage layer and related test workflows:
Dialect abstraction
• Introduced DBDialect interface and refactored pipeline/experiment/run/job stores to use it.
• Removed legacy SQLDialect, centralized initialization in InitDBClient.
Storage refactor
• Updated resource_reference, db_status_store, and cache/storage clients to use the new dialect.
• Moved filter logic into dialect package, cleaned up list package.
• Adapted db_fake to support dialect abstraction.
Tests & dependencies
• Updated unit tests across storage, list, and filter packages.
• Updated go.mod dependencies and tidied modules.
• Added PostgreSQL GitHub Actions workflow with kustomize deployment and port-forward.

CI Status

  • In the upstream CI, the failures are infra-related: tests share the same database and pollute each other.
  • Running the tests in parallel jobs resolves this issue and results in all tests passing, as shown in this PR's CI results.
  • Per maintainer feedback, PR#12251 was closed to make room for the ongoing test overhaul PR#12222.
  • This PR includes the fixes from PR#12251, so CI results here are green.

Copy link

Hi @kaikaila. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kaikaila kaikaila changed the title chore(backend): introduce dialect-aware LargeText type for cross-db text compatibility [WIP] chore(backend): introduce dialect-aware LargeText type for cross-db text compatibility Jul 17, 2025
Copy link

🚫 This command cannot be processed. Only organization members or owners can use the commands.

@kaikaila kaikaila changed the title [WIP] chore(backend): introduce dialect-aware LargeText type for cross-db text compatibility [WIP] chore(backend): define dialect-aware LargeText type for large string fields Jul 17, 2025
@kaikaila kaikaila force-pushed the feature/replace-str-with-largetext-WIP branch from 9deb920 to fb7b159 Compare August 14, 2025 22:26
@kaikaila kaikaila force-pushed the feature/replace-str-with-largetext-WIP branch from d8b6e72 to 73f9149 Compare August 16, 2025 00:27
@kaikaila kaikaila force-pushed the feature/replace-str-with-largetext-WIP branch from 73f9149 to f382b21 Compare August 16, 2025 04:39
@kaikaila kaikaila force-pushed the feature/replace-str-with-largetext-WIP branch 4 times, most recently from fb05e3c to efa6538 Compare August 18, 2025 05:42
@kaikaila kaikaila changed the title [WIP] chore(backend): define dialect-aware LargeText type for large string fields chore(backend): [Umbrella] Storage-layer refactor & Postgres (pgx) enablement roadmap (Do Not Merge) Aug 20, 2025
@kaikaila kaikaila changed the title chore(backend): [Umbrella] Storage-layer refactor & Postgres (pgx) enablement roadmap (Do Not Merge) chore(backend): [Umbrella] Storage-layer refactor & Postgres enablement roadmap (Do Not Merge) Aug 21, 2025
@kaikaila kaikaila force-pushed the feature/replace-str-with-largetext-WIP branch from 9d160d5 to 49126df Compare August 22, 2025 06:44
@kaikaila kaikaila force-pushed the feature/replace-str-with-largetext-WIP branch 8 times, most recently from ce0d462 to 6407e20 Compare October 16, 2025 05:11
apiserver launched successfully in kind cluster

Signed-off-by: kaikaila <[email protected]>
Signed-off-by: kaikaila <[email protected]>
Signed-off-by: kaikaila <[email protected]>
Signed-off-by: kaikaila <[email protected]>
Signed-off-by: kaikaila <[email protected]>
@kaikaila kaikaila force-pushed the feature/replace-str-with-largetext-WIP branch from 707691e to f9611bf Compare October 17, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants