Skip to content

Conversation

connor-mccarthy
Copy link
Member

Description of your changes:

Checklist:

Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from connor-mccarthy. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nithin8702
Copy link

Hi Team,
Is it possible to include this PR in this release?

#10471

@connor-mccarthy connor-mccarthy marked this pull request as ready for review February 13, 2024 17:45
Copy link

@connor-mccarthy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
test-run-all-gcpc-modules 55e9ab5 link true /test test-run-all-gcpc-modules
kfp-kubernetes-execution-tests 55e9ab5 link false /test kfp-kubernetes-execution-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@connor-mccarthy
Copy link
Member Author

@nithin8702, the changes in #10471 are released in kfp-kubernetes, so it is unrelated to the current release PR.

Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Feb 14, 2024
@connor-mccarthy connor-mccarthy merged commit ae62b11 into kubeflow:master Feb 14, 2024
KevinGrantLee pushed a commit to KevinGrantLee/pipelines that referenced this pull request Feb 15, 2024
petethegreat pushed a commit to petethegreat/pipelines that referenced this pull request Mar 27, 2024
petethegreat pushed a commit to petethegreat/pipelines that referenced this pull request Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants