Skip to content

fix(backend): Pipeline and PipelineVersion Description column value should be optional. #10205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2023
Merged

fix(backend): Pipeline and PipelineVersion Description column value should be optional. #10205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backend/src/apiserver/model/pipeline.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ type Pipeline struct {
UUID string `gorm:"column:UUID; not null; primary_key;"`
CreatedAtInSec int64 `gorm:"column:CreatedAtInSec; not null;"`
Name string `gorm:"column:Name; not null; unique_index:namespace_name;"` // Index improves performance of the List ang Get queries
Description string `gorm:"column:Description; not null; size:65535;"` // Same as below, set size to large number so it will be stored as longtext
Description string `gorm:"column:Description; size:65535;"` // Same as below, set size to large number so it will be stored as longtext
// TODO(gkcalat): this is deprecated. Consider removing and adding data migration logic at the server startup.
Parameters string `gorm:"column:Parameters; size:65535;"`
Status PipelineStatus `gorm:"column:Status; not null;"`
Expand Down
2 changes: 1 addition & 1 deletion backend/src/apiserver/model/pipeline_version.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ type PipelineVersion struct {
Status PipelineVersionStatus `gorm:"column:Status; not null;"`
// Code source url links to the pipeline version's definition in repo.
CodeSourceUrl string `gorm:"column:CodeSourceUrl;"`
Description string `gorm:"column:Description; not null; size:65535;"` // Set size to large number so it will be stored as longtext
Description string `gorm:"column:Description; size:65535;"` // Set size to large number so it will be stored as longtext
PipelineSpec string `gorm:"column:PipelineSpec; not null; size:33554432;"` // Same as common.MaxFileLength (32MB in server). Argo imposes 700kB limit
PipelineSpecURI string `gorm:"column:PipelineSpecURI; not null; size:65535;"` // Can store references to ObjectStore files
}
Expand Down