feat(ws): Notebooks 2.0 // Frontend // Workspaces table // Workspace redirect status column #147 #191
Conversation
|
/assign @paulovmr |
|
@asaadbalum thanks for the PR! @paulovmr can you please take a look on it? Meanwhile, @asaadbalum can you fix the PR title for semantic values and also sign the commits (DCO check)? |
asaadbalum
force-pushed
the
RHOAIENG-16238-2
branch
from
510c4e9 to
d3d1b6b
Compare
Is if fine now? |
paulovmr
left a comment
paulovmr
left a comment
There was a problem hiding this comment.
Hi @asaadbalum , to fix the semantic PRs check, your PR title needs to have a prefix following the Conventional commits specification. For notebooks 2.0 tasks, the scope is "ws", a reference to "workspaces". Therefore, the majority of pull request we are sending would have a name like "feat(ws): ". Considering that, if you add the "feat(ws): " prefix to your PR title, it should be fixed.
To fix the DCO check, you need to sign off your commits. There is information here with a few options on how to do it.
Also, everytime before submitting a PR, please consider running npm run test to check for linting and tests errors. Most of the formatting issues can be solved automatically with npm run test:fix.
asaadbalum
changed the title
asaadbalum
force-pushed
the
RHOAIENG-16238-2
branch
7 times, most recently
from
959de7a to
4c4a104
Compare
…redirect status column kubeflow#147 Signed-off-by: Asaad Balum <[email protected]>
asaadbalum
force-pushed
the
RHOAIENG-16238-2
branch
from
4c4a104 to
0b302f5
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ederign, paulovmr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
|
/ok-to-test |
|
/retest |
|
Ok, I have made a PR that should fix the workflows not running for new contributors (as long as the PR has the |
|
/lgtm |
…redirect status column kubeflow#147 (kubeflow#191) Signed-off-by: Asaad Balum <[email protected]>
…redirect status column kubeflow#147 (kubeflow#191) Signed-off-by: Asaad Balum <[email protected]> Signed-off-by: CI Bot <[email protected]>
…redirect status column kubeflow#147 (kubeflow#191) Signed-off-by: Asaad Balum <[email protected]>
4 participants
When Info/Warning/Danger redirection level:
When no BE response:
When wrong redirection level:
