-
Notifications
You must be signed in to change notification settings - Fork 1k
Documentation fix #3257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Documentation fix #3257
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
You need to sign you commits as desribed in https://github.com/kubeflow/manifests/pull/3257/checks?check_run_id=52443746965 |
common/dex/README.md
Outdated
| clientSecret: $CLIENT_SECRET | ||
| redirectURI: $REDIRECT_URI | ||
| insecure: false | ||
| insecureSkipVerify: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- the default should be false
- Please link in an inline comment about self-signed certificates to the dex documentation where this is documented
common/dex/README.md
Outdated
| app: istio-ingressgateway | ||
| jwtRules: | ||
| - issuer: $DEX_ISSUER | ||
| jwksUri: http://dex.auth.svc.cluster.local:5556/dex/keys |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert this. It should be a comment for the variable in line 156 DEX_ISSUER="https://kubeflow.example.com/dex". Please also link to the dex documentation or something that explains the change.
|
@Pradyumn-cloud your commits still have to be signed. |
Signed-off-by: Pradyumn-cloud <[email protected]>
Signed-off-by: Pradyumn-cloud <[email protected]>
Signed-off-by: Pradyumn-cloud <[email protected]>
Signed-off-by: Pradyumn-cloud <[email protected]>
a1113fb to
f16b1f1
Compare
common/dex/README.md
Outdated
| clientSecret: $CLIENT_SECRET | ||
| redirectURI: $REDIRECT_URI | ||
| insecure: false | ||
| # Set to true only for self-signed certificates. See: https://dexidp.io/docs/connectors/oidc/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not see "insecureSkipVerify" on the page you linked
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and an inline comment would be insecureSkipVerify: false # Set to true only for self-signed certificates. See: https://dexidp.io/docs/connectors/oidc/ in a single line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
insecureSkipVerify: false # Specify whether to communicate with the authentication provider without validating SSL certificates see https://dexidp.io/docs/connectors/oauth/ and https://dexidp.io/docs/connectors/oidc/
would be my guess but on the pages linked i see it in the oauth instead of the oidc section. CC @kromanow94 @kimwnasptd for more input
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oidc doc dont mention insecureSkipVerify instead oauth2.0 do.
So i am adding this line - insecureSkipVerify: false # Specify whether to communicate with the authentication provider without validating SSL certificates see https://dexidp.io/docs/connectors/oauth/ and https://dexidp.io/docs/connectors/oidc/.
Signed-off-by: Pradyumn-cloud <[email protected]>
Fix - #3244
Changes done as Mentioned in issue.
✅ Contributor Checklist