Skip to content

Conversation

akagami-harsh
Copy link
Contributor

Pull Request Template for Kubeflow Manifests

✏️ Summary of Changes

  • Replaces DockerHub image references (docker.io/istio) with GCR equivalents (gcr.io/istio-release) for Istio 1.24 and Istio-cni 1.24
  • Updates Istio manifests in common/istio-1-24/ and common/istio-cni-1-24/.

📦 Dependencies

List any dependencies or related PRs (e.g., "Depends on #123").

🐛 Related Issues

✅ Contributor Checklist


You can join the CNCF Slack and access our meetings at the Kubeflow Community website. Our channel on the CNCF Slack is here #kubeflow-platform.

@juliusvonkohout
Copy link
Member

juliusvonkohout commented Feb 28, 2025

Thank you @akagami-harsh please also upgrade/cleanup the readmes for istio and istio-cni https://github.com/kubeflow/manifests/blob/master/common/istio-cni-1-24/README.md https://github.com/kubeflow/manifests/blob/master/common/istio-1-24/README.md with the changes and use/upgrade the scripts in /hack https://github.com/kubeflow/manifests/blob/master/hack/synchronize-istio-manifests.sh and https://github.com/kubeflow/manifests/blob/master/hack/synchronize-istio-cni-manifests.sh with the commit to upgrade to the latest 1.24.3 https://github.com/istio/istio/releases/tag/1.24.3 release.

COMMIT="1.24.3"
CURRENT_VERSION="1-24" 
NEW_VERSION="1-24" # Must be a release

@juliusvonkohout juliusvonkohout added this to the 1.10 milestone Feb 28, 2025
@google-oss-prow google-oss-prow bot added size/M and removed size/S labels Feb 28, 2025
@juliusvonkohout
Copy link
Member

@akagami-harsh
Copy link
Contributor Author

@akagami-harsh please also upgrade/cleanup the readmes for istio and istio-cni https://github.com/kubeflow/manifests/blob/master/common/istio-cni-1-24/README.md https://github.com/kubeflow/manifests/blob/master/common/istio-1-24/README.md with the changes. you can also simplify them

Yes, i am working on it

@juliusvonkohout
Copy link
Member

Regarding image: busybox:1.28 we should use registry.k8s.io/busybox in the install.yaml. But this must somehow be configured in a persistent manner.

Signed-off-by: Harshvir Potpose <[email protected]>
Signed-off-by: Harshvir Potpose <[email protected]>
Signed-off-by: Harshvir Potpose <[email protected]>
Signed-off-by: Harshvir Potpose <[email protected]>
Signed-off-by: Harshvir Potpose <[email protected]>
Signed-off-by: Harshvir Potpose <[email protected]>
Signed-off-by: Harshvir Potpose <[email protected]>
Signed-off-by: Harshvir Potpose <[email protected]>
@juliusvonkohout
Copy link
Member

I am wondering which change is failing the three tests and i think you have to re-run the script to build the install.yaml etc. with the native sidecars.

@akagami-harsh
Copy link
Contributor Author

akagami-harsh commented Mar 4, 2025

The patchs were causing CI issues, so used image transformation to update busybox image instead.

@juliusvonkohout
Copy link
Member

juliusvonkohout commented Mar 5, 2025

I think you should also check #3035

@juliusvonkohout
Copy link
Member

I will try to review and merge it this week.

Signed-off-by: Julius von Kohout <[email protected]>
Signed-off-by: Julius von Kohout <[email protected]>
@juliusvonkohout
Copy link
Member

juliusvonkohout commented Mar 5, 2025

Actually i do not see how

      k8s:
        env:
        - name: ENABLE_NATIVE_SIDECARS
          value: "true"

has any effect. I cannot find the variable in the generated manifests.

apiVersion: apps/v1
kind: Deployment
metadata:
  name: istiod
  namespace: istio-system
spec:
  template:
    spec:
      containers:
      - env:
        - name: ENABLE_NATIVE_SIDECARS
          value: "true"
        name: discovery

should be the output

Signed-off-by: Julius von Kohout <[email protected]>
Signed-off-by: Julius von Kohout <[email protected]>
Signed-off-by: Julius von Kohout <[email protected]>
Signed-off-by: Julius von Kohout <[email protected]>
@juliusvonkohout
Copy link
Member

fixes #2958

@juliusvonkohout juliusvonkohout linked an issue Mar 5, 2025 that may be closed by this pull request
7 tasks
@juliusvonkohout
Copy link
Member

Thank you for the PR

/lgtm
/approve

Remaining is #3015 and the rest of #2958

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 194b543 into kubeflow:master Mar 5, 2025
19 checks passed
pschoen-itsc pushed a commit to pschoen-itsc/kf-manifests that referenced this pull request Apr 25, 2025
* switch to gcr from dockerhub

Signed-off-by: Harshvir Potpose <[email protected]>

* update scripts

Signed-off-by: Harshvir Potpose <[email protected]>

* update scritps and readmes

Signed-off-by: Harshvir Potpose <[email protected]>

* run synchronize scripts

Signed-off-by: Harshvir Potpose <[email protected]>

* add patches to update busybox image

Signed-off-by: Harshvir Potpose <[email protected]>

* update cluster-specific note

Signed-off-by: Harshvir Potpose <[email protected]>

* revert typo in synchronize script and rerun them

Signed-off-by: Harshvir Potpose <[email protected]>

* keep newer knative versions

Signed-off-by: Harshvir Potpose <[email protected]>

* Enable native sidecars in Istio CNI

Signed-off-by: Harshvir Potpose <[email protected]>

* Update istio CNI docs

Signed-off-by: Harshvir Potpose <[email protected]>

* use image transformation insted of patches

Signed-off-by: Harshvir Potpose <[email protected]>

* run istio-cni sync script

Signed-off-by: Harshvir Potpose <[email protected]>

* Update kustomization.yaml

Signed-off-by: Julius von Kohout <[email protected]>

* Update istio-ingressgateway-deployment.yaml

Signed-off-by: Julius von Kohout <[email protected]>

* Update istio-ingressgateway-deployment.yaml

Signed-off-by: Julius von Kohout <[email protected]>

* Update kustomization.yaml

Signed-off-by: Julius von Kohout <[email protected]>

* Update profile.yaml

Signed-off-by: Julius von Kohout <[email protected]>

* Update install.yaml

Signed-off-by: Julius von Kohout <[email protected]>

* Update kustomization.yaml

Signed-off-by: Julius von Kohout <[email protected]>

* Update kustomization.yaml

Signed-off-by: Julius von Kohout <[email protected]>

---------

Signed-off-by: Harshvir Potpose <[email protected]>
Signed-off-by: Julius von Kohout <[email protected]>
Co-authored-by: Julius von Kohout <[email protected]>
Signed-off-by: Patrick Schönthaler <[email protected]>
@akagami-harsh akagami-harsh deleted the switch-to-gcr branch June 4, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Istio: Gateway API, seccomp value, native sidecars, new registry

2 participants