-
Notifications
You must be signed in to change notification settings - Fork 1k
Migrate Istio images from DockerHub to GCR #3022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you @akagami-harsh please also upgrade/cleanup the readmes for istio and istio-cni https://github.com/kubeflow/manifests/blob/master/common/istio-cni-1-24/README.md https://github.com/kubeflow/manifests/blob/master/common/istio-1-24/README.md with the changes and use/upgrade the scripts in /hack https://github.com/kubeflow/manifests/blob/master/hack/synchronize-istio-manifests.sh and https://github.com/kubeflow/manifests/blob/master/hack/synchronize-istio-cni-manifests.sh with the commit to upgrade to the latest 1.24.3 https://github.com/istio/istio/releases/tag/1.24.3 release.
|
@akagami-harsh please also upgrade/cleanup the readmes for istio and istio-cni https://github.com/kubeflow/manifests/blob/master/common/istio-cni-1-24/README.md https://github.com/kubeflow/manifests/blob/master/common/istio-1-24/README.md with the changes. you can also simplify them |
Yes, i am working on it |
Regarding image: busybox:1.28 we should use registry.k8s.io/busybox in the install.yaml. But this must somehow be configured in a persistent manner. |
478887d
to
21b6092
Compare
9c78520
to
e08a45b
Compare
common/istio-1-24/istio-install/base/patches/update-busybox-image.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Harshvir Potpose <[email protected]>
Signed-off-by: Harshvir Potpose <[email protected]>
Signed-off-by: Harshvir Potpose <[email protected]>
Signed-off-by: Harshvir Potpose <[email protected]>
Signed-off-by: Harshvir Potpose <[email protected]>
Signed-off-by: Harshvir Potpose <[email protected]>
Signed-off-by: Harshvir Potpose <[email protected]>
Signed-off-by: Harshvir Potpose <[email protected]>
Signed-off-by: Harshvir Potpose <[email protected]>
I am wondering which change is failing the three tests and i think you have to re-run the script to build the install.yaml etc. with the native sidecars. |
Signed-off-by: Harshvir Potpose <[email protected]>
Signed-off-by: Harshvir Potpose <[email protected]>
The patchs were causing CI issues, so used image transformation to update busybox image instead. |
I think you should also check #3035 |
I will try to review and merge it this week. |
Signed-off-by: Julius von Kohout <[email protected]>
Signed-off-by: Julius von Kohout <[email protected]>
Signed-off-by: Julius von Kohout <[email protected]>
Signed-off-by: Julius von Kohout <[email protected]>
Actually i do not see how
has any effect. I cannot find the variable in the generated manifests.
should be the output |
Signed-off-by: Julius von Kohout <[email protected]>
Signed-off-by: Julius von Kohout <[email protected]>
Signed-off-by: Julius von Kohout <[email protected]>
Signed-off-by: Julius von Kohout <[email protected]>
fixes #2958 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juliusvonkohout The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* switch to gcr from dockerhub Signed-off-by: Harshvir Potpose <[email protected]> * update scripts Signed-off-by: Harshvir Potpose <[email protected]> * update scritps and readmes Signed-off-by: Harshvir Potpose <[email protected]> * run synchronize scripts Signed-off-by: Harshvir Potpose <[email protected]> * add patches to update busybox image Signed-off-by: Harshvir Potpose <[email protected]> * update cluster-specific note Signed-off-by: Harshvir Potpose <[email protected]> * revert typo in synchronize script and rerun them Signed-off-by: Harshvir Potpose <[email protected]> * keep newer knative versions Signed-off-by: Harshvir Potpose <[email protected]> * Enable native sidecars in Istio CNI Signed-off-by: Harshvir Potpose <[email protected]> * Update istio CNI docs Signed-off-by: Harshvir Potpose <[email protected]> * use image transformation insted of patches Signed-off-by: Harshvir Potpose <[email protected]> * run istio-cni sync script Signed-off-by: Harshvir Potpose <[email protected]> * Update kustomization.yaml Signed-off-by: Julius von Kohout <[email protected]> * Update istio-ingressgateway-deployment.yaml Signed-off-by: Julius von Kohout <[email protected]> * Update istio-ingressgateway-deployment.yaml Signed-off-by: Julius von Kohout <[email protected]> * Update kustomization.yaml Signed-off-by: Julius von Kohout <[email protected]> * Update profile.yaml Signed-off-by: Julius von Kohout <[email protected]> * Update install.yaml Signed-off-by: Julius von Kohout <[email protected]> * Update kustomization.yaml Signed-off-by: Julius von Kohout <[email protected]> * Update kustomization.yaml Signed-off-by: Julius von Kohout <[email protected]> --------- Signed-off-by: Harshvir Potpose <[email protected]> Signed-off-by: Julius von Kohout <[email protected]> Co-authored-by: Julius von Kohout <[email protected]> Signed-off-by: Patrick Schönthaler <[email protected]>
Pull Request Template for Kubeflow Manifests
✏️ Summary of Changes
docker.io/istio
) with GCR equivalents (gcr.io/istio-release
) for Istio 1.24 and Istio-cni 1.24common/istio-1-24/
andcommon/istio-cni-1-24/
.📦 Dependencies
🐛 Related Issues
✅ Contributor Checklist