Skip to content

Conversation

moficodes
Copy link
Contributor

@moficodes moficodes commented Apr 8, 2021

Which issue is resolved by this Pull Request:
Resolves #

Description of your changes:
IBM Kubeflow distribution for IKS

Checklist:

  • Unit tests pass:
    Make sure you have installed kustomize == 3.2.1
    1. make generate-changed-only
    2. make test

@google-cla
Copy link

google-cla bot commented Apr 9, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Apr 9, 2021
@Tomcli
Copy link
Member

Tomcli commented Apr 9, 2021

@googlebot I consent.

@google-cla google-cla bot added cla: yes and removed cla: no labels Apr 9, 2021
@moficodes moficodes changed the title WIP KF 1.3 IBM IKS release [IBM] KF 1.3 IBM IKS release Apr 16, 2021
@moficodes moficodes marked this pull request as ready for review April 16, 2021 23:12
@yanniszark
Copy link
Contributor

/lgtm
/approve
/hold
@moficodes feel free to remove when ready!

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: moficodes, yanniszark

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@moficodes
Copy link
Contributor Author

/hold

@animeshsingh
Copy link
Contributor

/assign to @yhwang who is running final tests for lgtm

cc @moficodes @yanniszark @Tomcli

@animeshsingh
Copy link
Contributor

/assign @yhwang

@google-oss-robot
Copy link

@animeshsingh: GitHub didn't allow me to assign the following users: yhwang.

Note that only kubeflow members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @yhwang

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yhwang
Copy link
Member

yhwang commented Apr 21, 2021

@moficodes seems kfserving is not in the kfdef yaml (both single user and multi user)

profile crds need to be created before we try to create profile instance
@Tomcli
Copy link
Member

Tomcli commented Apr 21, 2021

/lgtm

@moficodes
Copy link
Contributor Author

/unhold

@google-oss-robot google-oss-robot merged commit 3950fed into kubeflow:master Apr 21, 2021
moficodes added a commit to moficodes/manifests that referenced this pull request Apr 21, 2021
* application path update: certmanager, istio, authservice

* application path update: certmanager, istio, kfserving, knative

* delete deprecated/unused component

application path update: namespace, roles, katib, central dashboard

* application path update: notebook, tensorboard, mpi, xgboost...

* application path update: dex, mxnet, kfp-argo

* add kfp-tekton to ibm distribution

update oidc appid to create secret for clientId and secret
move kubeflow istio resources to own application folder

* ibm 1.3 kfdef

* change kubeflow istio resources to own applicaiton

* add fixed nodeport for istio ingressgateway

* Don't overwrite all namespaces to kubeflow

* add kfdef for ibm kubeflow 1.3

add dex for single user
add oauthservice for dex

* add new line at end of file

* kfdef reporef name fix

* kfdef reporef kustomization fix

* add moficodes and pvaneck to IBM distribution owners

remove adrian555 from IBM Distribution owners

* add kfserving to kfdef

* remove duplicate compononet from kfdef

* reorder profile component

profile crds need to be created before we try to create profile instance
google-oss-robot pushed a commit that referenced this pull request Apr 21, 2021
* application path update: certmanager, istio, authservice

* application path update: certmanager, istio, kfserving, knative

* delete deprecated/unused component

application path update: namespace, roles, katib, central dashboard

* application path update: notebook, tensorboard, mpi, xgboost...

* application path update: dex, mxnet, kfp-argo

* add kfp-tekton to ibm distribution

update oidc appid to create secret for clientId and secret
move kubeflow istio resources to own application folder

* ibm 1.3 kfdef

* change kubeflow istio resources to own applicaiton

* add fixed nodeport for istio ingressgateway

* Don't overwrite all namespaces to kubeflow

* add kfdef for ibm kubeflow 1.3

add dex for single user
add oauthservice for dex

* add new line at end of file

* kfdef reporef name fix

* kfdef reporef kustomization fix

* add moficodes and pvaneck to IBM distribution owners

remove adrian555 from IBM Distribution owners

* add kfserving to kfdef

* remove duplicate compononet from kfdef

* reorder profile component

profile crds need to be created before we try to create profile instance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants