Update Knative serving/eventing to 0.17 #1768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @Tomcli @animeshsingh |
|
@pvaneck quick question, is the new manifests recommend to have most stuff in one yaml? I want to understand is there any new practice in the design. |
|
@Tomcli I do not believe there is any specific recommendation, though it seems like the current practice is to split up by type of resource. In this case, I just thought it would be more straighforward to keep the upstream YAML in a structure that mirrors the YAML files Knative provides for those installing Knative manually. This way, one could presumably just download newer versions of |
|
/lgtm |
pvaneck
force-pushed
the
knative-update-0.17
branch
from
f11dd70 to
6b4ccc8
Compare
yuzisun
reviewed
Mar 31, 2021
pvaneck
force-pushed
the
knative-update-0.17
branch
3 times, most recently
from
f14d925 to
9c8103c
Compare
pvaneck
force-pushed
the
knative-update-0.17
branch
from
9c8103c to
1165a63
Compare
|
Validated this with the Kubeflow 1.3 manifests on K8s 1.18 using Minikube. Was able to spin up a KFServing InferenceService and curl a prediction using the X-Auth-Token header (because of Dex). |
pvaneck
force-pushed
the
knative-update-0.17
branch
from
1165a63 to
a6462a1
Compare
|
Validated Knative Eventing install by creating trigger and broker to log Inference requests on same K8s 1.18 minikube environment as above. Validated on OpenShift 4.5 using the Istio 1.9.0 and KFServing manifests in the master branch of this repo. @yanniszark Would be great to have this in for the Kubeflow 1.3 release if possible. The updated Knative brings additional configuration and features that would be useful in the context of KFServing. |
Added README to explain changes from upstream. YAML anchors and aliases are also removed/expanded as they sometimes cause breakages in kustomize v3.9+.
pvaneck
force-pushed
the
knative-update-0.17
branch
from
a6462a1 to
9bc303c
Compare
|
@yanniszark @pvaneck What's the plan to get this in ? |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pvaneck, yuzisun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Merged
yanniszark
added a commit
to arrikto/kubeflow-manifests
that referenced
this pull request
Jun 25, 2021
Added README to explain changes from upstream. YAML anchors and aliases are also removed/expanded as they sometimes cause breakages in kustomize v3.9+.
google-oss-robot
pushed a commit
that referenced
this pull request
Jun 25, 2021
* Add kimwnasptd to the owners file (#1898) Signed-off-by: Kimonas Sotirchos <[email protected]> * docs: Add 1.3 release retrospective (#1900) The original document is: https://docs.google.com/document/d/1KRF4IE48Ueb61DPBKK6fryRWSaNz_urXQOxWf4G_qD8 Signed-off-by: Yannis Zarkadas <[email protected]> * Change user name to [email protected] in README (#1902) * Change user name to [email protected] in README * Fix user namespace * Change user name to email * Add linguist configuration (#1905) * Update Knative serving/eventing to 0.17 (#1768) Added README to explain changes from upstream. YAML anchors and aliases are also removed/expanded as they sometimes cause breakages in kustomize v3.9+. * Update cert-manager manifests to 1.3.1 version (#1820) * update cert-manager manifests to latest version * review: make suggested change and update to 1.3.1 * Update cert-manager to 1.4.0 * Make suggested changes * Downgrade to 1.3.1 * Fix image tags and add comment about preserveUnknownFields patch * Remove images section and cleanup * cert-manager: Split kubeflow-issuer into separate kustomization (#1916) Signed-off-by: Yannis Zarkadas <[email protected]> * Upgrade Istio to 1.9.5 (#1908) * common: Upgrade to Istio 1.9.5 Signed-off-by: Yannis Zarkadas <[email protected]> * common: Fix all references to new Istio 1.9.5 Signed-off-by: Yannis Zarkadas <[email protected]> * Knative 0.17 (#1917) * knative: Document how to update Knative Signed-off-by: Yannis Zarkadas <[email protected]> * knative: Restructure to eventing and serving kustomizations Signed-off-by: Yannis Zarkadas <[email protected]> * knative: Apply changes according to guide Signed-off-by: Yannis Zarkadas <[email protected]> * knative: Remove old kustomizations Signed-off-by: Yannis Zarkadas <[email protected]> * knative: Enable sidecar injection for serving Signed-off-by: Yannis Zarkadas <[email protected]> * knative: Fix example kustomization and guide Signed-off-by: Yannis Zarkadas <[email protected]> * Sync manifests for 1.3.1 (#1919) * Notebook Controller: Sync manifests Sync manifests for application "Notebook Controller". Upstream manifests are copied from: - Repo: https://github.com/kubeflow/kubeflow - Path: components/notebook-controller/config - Revision: v1.3.1-rc.0 Signed-off-by: Yannis Zarkadas <[email protected]> * Tensorboard Controller: Sync manifests Sync manifests for application "Tensorboard Controller". Upstream manifests are copied from: - Repo: https://github.com/kubeflow/kubeflow - Path: components/tensorboard-controller/config - Revision: v1.3.1-rc.0 Signed-off-by: Yannis Zarkadas <[email protected]> * Central Dashboard: Sync manifests Sync manifests for application "Central Dashboard". Upstream manifests are copied from: - Repo: https://github.com/kubeflow/kubeflow - Path: components/centraldashboard/manifests - Revision: v1.3.1-rc.0 Signed-off-by: Yannis Zarkadas <[email protected]> * Profiles + KFAM: Sync manifests Sync manifests for application "Profiles + KFAM". Upstream manifests are copied from: - Repo: https://github.com/kubeflow/kubeflow - Path: components/profile-controller/config - Revision: v1.3.1-rc.0 Signed-off-by: Yannis Zarkadas <[email protected]> * PodDefaults Webhook: Sync manifests Sync manifests for application "PodDefaults Webhook". Upstream manifests are copied from: - Repo: https://github.com/kubeflow/kubeflow - Path: components/admission-webhook/manifests - Revision: v1.3.1-rc.0 Signed-off-by: Yannis Zarkadas <[email protected]> * Jupyter Web App: Sync manifests Sync manifests for application "Jupyter Web App". Upstream manifests are copied from: - Repo: https://github.com/kubeflow/kubeflow - Path: components/crud-web-apps/jupyter/manifests - Revision: v1.3.1-rc.0 Signed-off-by: Yannis Zarkadas <[email protected]> * Tensorboards Web App: Sync manifests Sync manifests for application "Tensorboards Web App". Upstream manifests are copied from: - Repo: https://github.com/kubeflow/kubeflow - Path: components/crud-web-apps/tensorboards/manifests - Revision: v1.3.1-rc.0 Signed-off-by: Yannis Zarkadas <[email protected]> * Volumes Web App: Sync manifests Sync manifests for application "Volumes Web App". Upstream manifests are copied from: - Repo: https://github.com/kubeflow/kubeflow - Path: components/crud-web-apps/volumes/manifests - Revision: v1.3.1-rc.0 Signed-off-by: Yannis Zarkadas <[email protected]> * Katib: Sync manifests Sync manifests for application "Katib". Upstream manifests are copied from: - Repo: https://github.com/kubeflow/katib - Path: manifests/v1beta1 - Revision: v0.11.1 Signed-off-by: Yannis Zarkadas <[email protected]> * Kubeflow Pipelines: Sync manifests Sync manifests for application "Kubeflow Pipelines". Upstream manifests are copied from: - Repo: https://github.com/kubeflow/pipelines - Path: manifests/kustomize - Revision: 1.5.1 Signed-off-by: Yannis Zarkadas <[email protected]> * Kubeflow Tekton Pipelines: Sync manifests Sync manifests for application "Kubeflow Tekton Pipelines". Upstream manifests are copied from: - Repo: https://github.com/kubeflow/kfp-tekton - Path: manifests/kustomize - Revision: v0.8.0 Signed-off-by: Yannis Zarkadas <[email protected]> * README: Update component versions Signed-off-by: Yannis Zarkadas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue is resolved by this Pull Request:
Resolves #1754
Description of your changes:
upstreamfolder was made in respective folders to contain the resource YAMLS that were retrieved from the upstream release assets.I validated this with Kubeflow 1.3 manifests on K8s 1.18 using Minikube. Was able to spin up a KFServing InferenceService and curl a prediction using the X-Auth-Token header (because of Dex). I also tested Knative Eventing by creating trigger and broker to log Inference requests which worked fine.
Also Validated on OpenShift 4.5 using the Istio 1.9.0 and KFServing manifests in the master branch of this repo.
Checklist: