Skip to content

Unittest to validate admission web hooks don't apply to themselves #1213

@jlewi

Description

@jlewi

We've experienced a number of problems in Kubeflow where admission webhooks don't use a namespace or objectselector to prevent the admission hook from applying to itself.

This can cause outages e.g.

kubeflow/kubeflow#4808
kserve/kserve#568

We should be able to prevent this by ensuring Kubeflow admission hooks use a namespace selector or object selector to prevent them from applying to themselves.

We should add a unittest to try to verify this. We can model the unittest on
https://github.com/kubeflow/manifests/blob/master/tests/validate_resources_test.go

This test searches all KF manifests and verifies that certain resources conform to certain standards.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions