Skip to content

Conversation

tenzen-y
Copy link
Member

What this PR does / why we need it:
My bandwidth for this project is very limited, and I have not been actively working on it recently.
So, I decided to step down from the Approver role.

Thank you for the great 5-year journey. I was honored to contribute to expanding the Kubeflow AutoML project.
After this PR, I will open another PR to step down from the AutoML TL role.

/assign @kubeflow/wg-automl-leads

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all of your contributions to Katib over the past 5 years @tenzen-y!
We wouldn't create such awesome tool without you!
cc @gaocegege @johnugeorge @Electronic-Waste

Would you mind adding yourself to emeritus_approvers please ?

@tenzen-y tenzen-y force-pushed the tenzen-y-step-down branch from 96e1db7 to 6440a89 Compare July 27, 2025 23:17
@tenzen-y
Copy link
Member Author

Thank you for all of your contributions to Katib over the past 5 years @tenzen-y! We wouldn't create such awesome tool without you! cc @gaocegege @johnugeorge @Electronic-Waste

Would you mind adding yourself to emeritus_approvers please ?

done.

Copy link
Member

@Electronic-Waste Electronic-Waste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tenzen-y Thanks for what you did in the past! Awesome.
And I can't forget that you helped me a lot in the last year's GSoC project. Really appreciate it! Llooking forward to working with you in other projects in the future.

/lgtm

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit fe7a35d into kubeflow:master Jul 28, 2025
73 of 78 checks passed
@tenzen-y tenzen-y deleted the tenzen-y-step-down branch July 28, 2025 13:40
tenzen-y added a commit to tenzen-y/kf-internal-acls that referenced this pull request Jul 29, 2025
@terrytangyuan
Copy link
Member

Thank you for all your contributions over the years!

ram4444 pushed a commit to ram4444/katib that referenced this pull request Aug 15, 2025
google-oss-prow bot pushed a commit that referenced this pull request Aug 23, 2025
* Out-of-the-box support TrainJob

Signed-off-by: Ram Lau <[email protected]>

* Example for Pytorch Distributed

Signed-off-by: Ram Lau <[email protected]>

* Update examples/v1beta1/kubeflow-training-operator/trainjob-pytorch.yaml

Co-authored-by: Andrey Velichkevich <[email protected]>
Signed-off-by: Ram Lau <[email protected]>

* Create folder for Trainer as suggested

Signed-off-by: Ram Lau <[email protected]>

* Movethe exmaple of trainjob to the new folder

Signed-off-by: Ram Lau <[email protected]>

* Ref the primaryContainerName to that of ClusterTrainingRuntime

Signed-off-by: Ram Lau <[email protected]>

* tenzen-y steps down from Katib approver role (#2561)

Signed-off-by: Yuki Iwai <[email protected]>
Signed-off-by: Ram Lau <[email protected]>

* Set Default value for TrainJob Success, Failure Condition and PrimaryPodLabels in the trial Template

Signed-off-by: Ram Lau <[email protected]>

* Enchance Handling for default value of Success, Fail Cond & Pod Label

Signed-off-by: Ram Lau <[email protected]>

* Bug fix for default value condition

Signed-off-by: Ram Lau <[email protected]>

* code format by hack/update-gofmt.sh

Signed-off-by: Ram Lau <[email protected]>

* add TrainJob trial Resources to cert manager config

Signed-off-by: Ram Lau <[email protected]>

* add trainjob to controller rbac

Signed-off-by: Ram Lau <[email protected]>

* Grant JobSet permission to Katib controller

Signed-off-by: Andrey Velichkevich <[email protected]>

* Remove create/delete RBAC for TrainJob

Signed-off-by: Andrey Velichkevich <[email protected]>

* Fix docker build with libpcre2

Signed-off-by: Andrey Velichkevich <[email protected]>

---------

Signed-off-by: Ram Lau <[email protected]>
Signed-off-by: Yuki Iwai <[email protected]>
Signed-off-by: Andrey Velichkevich <[email protected]>
Co-authored-by: Andrey Velichkevich <[email protected]>
Co-authored-by: Yuki Iwai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants