-
Notifications
You must be signed in to change notification settings - Fork 486
tenzen-y steps down from Katib approver role #2561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4841d71
to
96e1db7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for all of your contributions to Katib over the past 5 years @tenzen-y!
We wouldn't create such awesome tool without you!
cc @gaocegege @johnugeorge @Electronic-Waste
Would you mind adding yourself to emeritus_approvers
please ?
Signed-off-by: Yuki Iwai <[email protected]>
96e1db7
to
6440a89
Compare
done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tenzen-y Thanks for what you did in the past! Awesome.
And I can't forget that you helped me a lot in the last year's GSoC project. Really appreciate it! Llooking forward to working with you in other projects in the future.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
REF: kubeflow/katib#2561 Signed-off-by: Yuki Iwai <[email protected]>
Thank you for all your contributions over the years! |
Signed-off-by: Yuki Iwai <[email protected]> Signed-off-by: Ram Lau <[email protected]>
* Out-of-the-box support TrainJob Signed-off-by: Ram Lau <[email protected]> * Example for Pytorch Distributed Signed-off-by: Ram Lau <[email protected]> * Update examples/v1beta1/kubeflow-training-operator/trainjob-pytorch.yaml Co-authored-by: Andrey Velichkevich <[email protected]> Signed-off-by: Ram Lau <[email protected]> * Create folder for Trainer as suggested Signed-off-by: Ram Lau <[email protected]> * Movethe exmaple of trainjob to the new folder Signed-off-by: Ram Lau <[email protected]> * Ref the primaryContainerName to that of ClusterTrainingRuntime Signed-off-by: Ram Lau <[email protected]> * tenzen-y steps down from Katib approver role (#2561) Signed-off-by: Yuki Iwai <[email protected]> Signed-off-by: Ram Lau <[email protected]> * Set Default value for TrainJob Success, Failure Condition and PrimaryPodLabels in the trial Template Signed-off-by: Ram Lau <[email protected]> * Enchance Handling for default value of Success, Fail Cond & Pod Label Signed-off-by: Ram Lau <[email protected]> * Bug fix for default value condition Signed-off-by: Ram Lau <[email protected]> * code format by hack/update-gofmt.sh Signed-off-by: Ram Lau <[email protected]> * add TrainJob trial Resources to cert manager config Signed-off-by: Ram Lau <[email protected]> * add trainjob to controller rbac Signed-off-by: Ram Lau <[email protected]> * Grant JobSet permission to Katib controller Signed-off-by: Andrey Velichkevich <[email protected]> * Remove create/delete RBAC for TrainJob Signed-off-by: Andrey Velichkevich <[email protected]> * Fix docker build with libpcre2 Signed-off-by: Andrey Velichkevich <[email protected]> --------- Signed-off-by: Ram Lau <[email protected]> Signed-off-by: Yuki Iwai <[email protected]> Signed-off-by: Andrey Velichkevich <[email protected]> Co-authored-by: Andrey Velichkevich <[email protected]> Co-authored-by: Yuki Iwai <[email protected]>
What this PR does / why we need it:
My bandwidth for this project is very limited, and I have not been actively working on it recently.
So, I decided to step down from the Approver role.
Thank you for the great 5-year journey. I was honored to contribute to expanding the Kubeflow AutoML project.
After this PR, I will open another PR to step down from the AutoML TL role.
/assign @kubeflow/wg-automl-leads
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Checklist: