Narrow down RBAC rules #2091
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,19 +7,38 @@ rules: | |
| - apiGroups: | ||
| - "" | ||
| resources: | ||
| - services | ||
| - events | ||
| verbs: | ||
| - "*" | ||
| - apiGroups: | ||
| - "" | ||
| resources: | ||
| - serviceaccounts | ||
| - persistentvolumes | ||
| - persistentvolumeclaims | ||
| verbs: | ||
| - "get" | ||
| - "list" | ||
| - "watch" | ||
| - "create" | ||
| - apiGroups: | ||
| - "" | ||
| resources: | ||
| - namespaces | ||
|
There was a problem hiding this comment. Do we need permission for namespace in the Controller @johnugeorge @tenzen-y ? There was a problem hiding this comment. As I can see, we operate namespaces only from UI. So we can remove the permission for namespaces. There was a problem hiding this comment. Yes. It is needed only in UI. There was a problem hiding this comment. I retested it. Currently, Katib needs get/list/watch for namespaces as well. Need to investigate separately |
||
| - configmaps | ||
| verbs: | ||
| - "get" | ||
| - "list" | ||
| - "watch" | ||
| - apiGroups: | ||
| - "" | ||
| resources: | ||
| - pods | ||
| - pods/log | ||
| - pods/status | ||
| verbs: | ||
| - "get" | ||
| - apiGroups: | ||
| - apps | ||
| resources: | ||
|
|
@@ -32,7 +51,10 @@ rules: | |
| - roles | ||
| - rolebindings | ||
| verbs: | ||
| - "get" | ||
| - "create" | ||
| - "list" | ||
| - "watch" | ||
| - apiGroups: | ||
| - batch | ||
| resources: | ||
|
There was a problem hiding this comment. @johnugeorge Should we limit scope for There was a problem hiding this comment. we do get/create/delete/watch for all |
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need
*for services ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. We do it in https://github.com/kubeflow/katib/blob/master/pkg/controller.v1beta1/suggestion/suggestion_controller_util.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do get/create/delete/watch