WIP - Feature elena kwa eslint dummy #2035
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: elenzio9 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@andreyvelich @johnugeorge @tenzen-y I created this |
Remove TSLint since it's deprecated. Signed-off-by: Elena Zioga <[email protected]>
Introduce ESLint by using the following Angular command [1]: ng add @angular-eslint/schematics [1] https://github.com/angular-eslint/angular-eslint#quick-start-with-angular-v12-and-later Signed-off-by: Elena Zioga <[email protected]>
Fix linting errors. Signed-off-by: Elena Zioga <[email protected]>
elenzio9
force-pushed
the
feature-elena-kwa-eslint-dummy
branch
from
1269c36 to
87613ea
Compare
There was a problem hiding this comment.
Since the test-node.yaml workflow is only getting triggered for the files of pkg/new-ui/frontend let's update the definition to trigger it only when these files change. Especially since in the future we'll be extending it to run unit tests.
You can take a peek on how we do it in kubeflow/kubeflow in https://github.com/kubeflow/kubeflow/blob/master/.github/workflows/frontend_lint.yaml#L7
.github/workflows/test-node.yaml
Outdated
| lint-kwa-code: | ||
| name: Lint katib web app | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Check out code | ||
| - uses: actions/checkout@v3 | ||
|
|
||
| - name: Setup Node | ||
| - uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: 12.18.1 | ||
|
|
||
| - name: Lint katib web app | ||
| run: | | ||
| cd pkg/new-ui/v1beta1/frontend | ||
| npm run lint-check |
There was a problem hiding this comment.
@elenzio9 could you merge this job with the above one that runs prettier? Let's have only one job with name Code format and lint
There was a problem hiding this comment.
Adding the following lines did trigger the test-node.yaml workflow, so I'll go ahead and send the PR.
paths:
- pkg/new-ui/v1beta1/frontend/**
There was a problem hiding this comment.
@kimwnasptd Thanks for your help!
* Introduce a Github action to run a lint check. Signed-off-by: Elena Zioga <[email protected]>
Signed-off-by: Elena Zioga <[email protected]>
elenzio9
force-pushed
the
feature-elena-kwa-eslint-dummy
branch
from
87613ea to
739a08f
Compare
2 participants
Test linting by creating a dummy file.