Skip to content

Conversation

YujiOshima
Copy link
Contributor

Currently, we get a build error around docker package when we use vendored package.

go build github.com/kubeflow/hp-tuning/manager
# github.com/kubeflow/hp-tuning/vendor/github.com/docker/docker/client
vendor/github.com/docker/docker/client/container_commit.go:17:15: undefined: reference.ParseNormalizedNamed
vendor/github.com/docker/docker/client/container_commit.go:25:9: undefined: reference.TagNameOnly
vendor/github.com/docker/docker/client/container_commit.go:30:16: undefined: reference.FamiliarName
vendor/github.com/docker/docker/client/image_create.go:17:14: undefined: reference.ParseNormalizedNamed
vendor/github.com/docker/docker/client/image_create.go:23:25: undefined: reference.FamiliarName
vendor/github.com/docker/docker/client/image_import.go:19:16: undefined: reference.ParseNormalizedNamed
vendor/github.com/docker/docker/client/image_pull.go:24:14: undefined: reference.ParseNormalizedNamed
vendor/github.com/docker/docker/client/image_pull.go:30:25: undefined: reference.FamiliarName
vendor/github.com/docker/docker/client/image_pull.go:60:8: undefined: reference.TagNameOnly
vendor/github.com/docker/docker/client/image_push.go:20:14: undefined: reference.ParseNormalizedNamed
vendor/github.com/docker/docker/client/image_push.go:20:14: too many errors

Trying to use the latest docker(moby), go dep cannnot resolve dependency error.
For now, we should use docker 1.3.1.
Kubernetes looks using docker 1.2.0 ( https://github.com/kubernetes/kubernetes/blob/master/Godeps/Godeps.json#L1046 ).

/assign @gaocegege

Signed-off-by: YujiOshima [email protected]

Signed-off-by: YujiOshima <[email protected]>
@gaocegege
Copy link
Member

/lgtm Sorry for the mistake.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaocegege gaocegege merged commit 293c6ba into kubeflow:master Apr 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants