Skip to content

Conversation

andreyvelich
Copy link
Member

We should update our SDK version to the latest in the master branch.

/assign @gaocegege @tenzen-y @johnugeorge

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 74.264% when pulling 458eee7 on andreyvelich:bump-sdk-version-0.13.0rc0 into 98284f3 on kubeflow:master.

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this update @andreyvelich !
I think it would be better to add Python 3.8 ~ 3.10 to the following field.
WDYT? @andreyvelich

'Programming Language :: Python :: 2',
'Programming Language :: Python :: 2.7',
'Programming Language :: Python :: 3',
'Programming Language :: Python :: 3.6',
'Programming Language :: Python :: 3.7',

@andreyvelich
Copy link
Member Author

Thank you for this update @andreyvelich ! I think it would be better to add Python 3.8 ~ 3.10 to the following field. WDYT? @andreyvelich

'Programming Language :: Python :: 2',
'Programming Language :: Python :: 2.7',
'Programming Language :: Python :: 3',
'Programming Language :: Python :: 3.6',
'Programming Language :: Python :: 3.7',

It makes sense.
Do we want to support Python 3.6 and 3.7 in our SDK ?

I think we can update it in the following PR.

@tenzen-y
Copy link
Member

tenzen-y commented Jan 25, 2022

Thank you for this update @andreyvelich ! I think it would be better to add Python 3.8 ~ 3.10 to the following field. WDYT? @andreyvelich

'Programming Language :: Python :: 2',
'Programming Language :: Python :: 2.7',
'Programming Language :: Python :: 3',
'Programming Language :: Python :: 3.6',
'Programming Language :: Python :: 3.7',

It makes sense. Do we want to support Python 3.6 and 3.7 in our SDK ?

I think we can update it in the following PR.

I think it needs to support Python 3.7 in our SDK since Python 3.7 will be kept until 2023-06-27 according to this document.

@tenzen-y
Copy link
Member

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jan 25, 2022
@google-oss-prow google-oss-prow bot merged commit 22fc2fe into kubeflow:master Jan 25, 2022
@andreyvelich andreyvelich deleted the bump-sdk-version-0.13.0rc0 branch January 25, 2022 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants