Skip to content

Change namespace label for metrics collector injection #1740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 23, 2021
Merged

Change namespace label for metrics collector injection #1740

merged 2 commits into from
Nov 23, 2021

Conversation

andreyvelich
Copy link
Member

@andreyvelich andreyvelich commented Nov 22, 2021 •
edited
Loading

Related: #1622.

This PR changes label for Katib Metrics Collector injection to katib.kubeflow.org/metrics-collector-injection: enabled.

I will create PRs to fix profile controller and manifests.

/assign @gaocegege @alculquicondor @johnugeorge @tenzen-y

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andreyvelich andreyvelich mentioned this pull request Nov 22, 2021
Closed
2 tasks
@coveralls
Copy link

coveralls commented Nov 22, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.08%) to 73.786% when pulling f725274 on andreyvelich:issue-1622-change-namespace-label into 0e17302 on kubeflow:master.

gaocegege
gaocegege reviewed Nov 23, 2021
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Nov 23, 2021
@google-oss-prow google-oss-prow bot merged commit c3e778b into kubeflow:master Nov 23, 2021
@andreyvelich andreyvelich deleted the issue-1622-change-namespace-label branch November 23, 2021 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaocegege gaocegege gaocegege left review comments

@ca-scribner ca-scribner Awaiting requested review from ca-scribner

@johnugeorge johnugeorge Awaiting requested review from johnugeorge

@sperlingxx sperlingxx Awaiting requested review from sperlingxx

Assignees

@alculquicondor alculquicondor

@johnugeorge johnugeorge

@gaocegege gaocegege

@tenzen-y tenzen-y

Labels
approved lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@andreyvelich @coveralls @gaocegege @alculquicondor @johnugeorge @tenzen-y