Skip to content

Conversation

andreyvelich
Copy link
Member

I forgot to run the Early Stopping Pipeline in this PR: #1632.
I added updated example.

/assign @gaocegege @johnugeorge @tenzen-y

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 73.626% when pulling d46c9b1 on andreyvelich:run-early-stopping-pipeline into 0a38e87 on kubeflow:master.

"\n",
"**Note**: This Pipeline runs in the multi-user mode. Follow [this guide](https://github.com/kubeflow/katib/tree/master/examples/v1beta1/kubeflow-pipelines#multi-user-pipelines-setup) to give your Notebook access to Kubeflow Pipelines."
]
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #2.    !pip install kfp==1.8.4

I found a newer kfp Python library in [PyPI](https://pypi.org/project/kfp/#history). What do you think about this library version?


Reply via ReviewNB

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this version was released recently.
We can start to use it as part of Katib 0.13 release, since we are going to update Katib SDK version too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense.

@tenzen-y
Copy link
Member

Nice catch! @andreyvelich

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
/lgtm

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit b8622d6 into kubeflow:master Oct 29, 2021
@andreyvelich andreyvelich deleted the run-early-stopping-pipeline branch October 29, 2021 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants