Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should migrate to Go modules from
dep
since it is not longer supported from 2020: https://github.com/golang/dep#dep.Also to avoid errors like this: #1436 (comment).
Currently, I am using the same package versions with
k8s.io/kubernetes v1.13.3
andsigs.k8s.io/controller-runtime v0.1.9
which is very old.Unfortunately, I can't switch to the newer version because of this: #1405.
Controller runtime doesn't have dynamic webhook creation from v0.2.0.
We should disable dynamic webhook creation, update the versions and clean-up modules.
As well I fixed folder name in
Build Docker images
GitHub actions workflow. What do you think @DomFleischmann @RFMVasconcelos ?Please take a look @gaocegege @johnugeorge.