Skip to content

Conversation

knkski
Copy link
Contributor

@knkski knkski commented Jan 7, 2021

What this PR does / why we need it:

Adds SVG logo traced from bitmap logo, for use in contexts that require vector graphics. Includes both just logo, and logo with "Katib" title below it. Also symlinks icon.svg to the new logo file for each charm.

@@ -0,0 +1,17 @@
<svg xmlns="http://www.w3.org/2000/svg" height="762" width="548">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreyvelich
Copy link
Member

/retest

@PatrickXYS
Copy link
Member

/test kubeflow-katib-presubmit

@knkski
Copy link
Contributor Author

knkski commented Jan 20, 2021

I updated the PNG logo as well. I switched to the Urbanist font vs Calibri, as Calibri is not licensed for use on non-Windows machines. I chose Urbanist after looking around for fonts that had the same clean, straight design, but can switch it to another font if desired.

@@ -0,0 +1,17 @@
<svg xmlns="http://www.w3.org/2000/svg" height="762" width="548">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should update the README link as well: https://github.com/kubeflow/katib/blame/master/README.md#L2.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated that link, and also added pngs of both SVG files as logo.png and logo-title.png, to match the SVG filenames.

For future reference, making the pngs was pretty easy, if they ever get edited again:

cd docs/images/
inkscape logo.svg -o logo.png
inkscape logo-title.svg -o logo-title.png

@gaocegege
Copy link
Member

/lgtm

Thanks for your contribution! 🎉 👍

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this @knkski!
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, knkski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 26bcfea into kubeflow:master Jan 25, 2021
@knkski knkski deleted the add-logo-svg branch January 25, 2021 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants