Skip to content

Remove istio sidecar annotation from all examples #1338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 27, 2020
Merged

Remove istio sidecar annotation from all examples #1338

merged 5 commits into from
Oct 27, 2020

Conversation

@andreyvelich
Copy link
Member

Related: #1214.

I added sidecar.istio.io/inject: "false" to all examples.
Since we support custom CRD that should be added manually.

@kubeflow-bot
Copy link

This change is Reviewable

@andreyvelich
Copy link
Member Author

/assign @gaocegege @johnugeorge

@andreyvelich
Copy link
Member Author

/retest

1 similar comment
@andreyvelich
Copy link
Member Author

/retest

@andreyvelich andreyvelich force-pushed the add-istio-annotation-manually branch from c0a9ae4 to 46d4393 Compare October 14, 2020 02:01
@andreyvelich
Copy link
Member Author

andreyvelich commented Oct 14, 2020 •
edited
Loading

After discussion with @johnugeorge, we decided to delete istio annotation from the examples.
It makes easier to read the example for users and that change requires only if Istio is used.

We should update documentation with this information, like we did for PyTorch Job.

/cc @gaocegege

@andreyvelich andreyvelich changed the title Manually add istio sidecar annotation to all examples Remove istio sidecar annotation from all examples Oct 14, 2020
@gaocegege
Copy link
Member

/lgtm

This was referenced Oct 17, 2020
Closed
Closed
@aws-kf-ci-bot
Copy link
Contributor

aws-kf-ci-bot commented Oct 22, 2020 •
edited
Loading

@andreyvelich: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-katib-presubmit 13ef2c9 link /test kubeflow-katib-presubmit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@andreyvelich andreyvelich force-pushed the add-istio-annotation-manually branch from 13ef2c9 to 3c20962 Compare October 26, 2020 19:42
@andreyvelich andreyvelich force-pushed the add-istio-annotation-manually branch from 3c20962 to 2a90507 Compare October 26, 2020 21:34
gaocegege
gaocegege reviewed Oct 27, 2020
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [andreyvelich,gaocegege]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 614f9f8 into kubeflow:master Oct 27, 2020
@andreyvelich andreyvelich deleted the add-istio-annotation-manually branch October 6, 2021 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gaocegege gaocegege gaocegege left review comments

@sperlingxx sperlingxx Awaiting requested review from sperlingxx

Assignees

@johnugeorge johnugeorge

@gaocegege gaocegege

Labels

approved lgtm size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@andreyvelich @kubeflow-bot @gaocegege @aws-kf-ci-bot @k8s-ci-robot @johnugeorge