-
Notifications
You must be signed in to change notification settings - Fork 486
Add manifests/dlk in deploy.sh #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add katib-cli download command for Mac
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Merge master from kubeflow/katib
/assign @jlewi |
/unassign @jlewi /ok-to-test |
@YujiOshima - are you able to take a quick look at this change? |
@vinaykakade The dlk is already deprecated after #74. |
@YujiOshima Done @vinaykakade Thanks for your contribution while I think maybe we do not need to add dlk anymore, could you please close the issue? |
And, if you are interested in the development of katib, you could get start with these issues: https://github.com/kubeflow/katib/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22 😄 |
Thanks, closing this. BTW, since dlk is no longer used, the references to it should be deleted from the top level manifests, but that is a topic of separate issue! |
Should we remove dlk from the repository? Maybe we could open an issue. |
@gaocegege @vinaykakade |
While working through the getting started instructions, noticed that manifests/dlk is not part of deploy.sh, and so the examples do not work and the workers are not spawned. Verified that the workers are spawned correctly after adding manifests/dlk to deploy.sh
cc @mayankjuneja