Skip to content

Conversation

vinaykakade
Copy link
Contributor

While working through the getting started instructions, noticed that manifests/dlk is not part of deploy.sh, and so the examples do not work and the workers are not spawned. Verified that the workers are spawned correctly after adding manifests/dlk to deploy.sh

cc @mayankjuneja

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: jlewi

Assign the PR to them by writing /assign @jlewi in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vinaykakade
Copy link
Contributor Author

/assign @jlewi

@gaocegege
Copy link
Member

/unassign @jlewi
/assign @YujiOshima

/ok-to-test

@vinaykakade
Copy link
Contributor Author

@YujiOshima - are you able to take a quick look at this change?

@YujiOshima
Copy link
Contributor

@vinaykakade The dlk is already deprecated after #74.
We don't need dlk deployment in the latest code.
We will release a new version soon. Please use it.
@gaocegege Could you release v0.1.2-alpha with the current master?

@gaocegege
Copy link
Member

@YujiOshima Done

@vinaykakade Thanks for your contribution while I think maybe we do not need to add dlk anymore, could you please close the issue?

@gaocegege
Copy link
Member

And, if you are interested in the development of katib, you could get start with these issues: https://github.com/kubeflow/katib/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22

😄

@vinaykakade
Copy link
Contributor Author

Thanks, closing this. BTW, since dlk is no longer used, the references to it should be deleted from the top level manifests, but that is a topic of separate issue!

@vinaykakade vinaykakade closed this Jun 6, 2018
@gaocegege
Copy link
Member

@YujiOshima

Should we remove dlk from the repository? Maybe we could open an issue.

@YujiOshima
Copy link
Contributor

@gaocegege @vinaykakade
Yes, we should remove. I'm sorry to forget to remove it.
@vinaykakade Thank you!!

@gaocegege gaocegege mentioned this pull request Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants