Skip to content

Suggestion services folder structure #1144

@andreyvelich

Description

@andreyvelich

/kind feature

Currently, we store all suggestion <algorithm_name>_service.py files under /pkg/suggestion/v1alpha3 directory.

Is there are reason to have structure like that? For example, for Golang Algorithms we have to store service in the same package as other files for the algorithm (See comment: #1131 (comment)).

I think we can add <algorithm_name>_service.py files to appropriate algorithm folder.

For example, hyperopt_service.py to https://github.com/kubeflow/katib/tree/master/pkg/suggestion/v1alpha3/hyperopt.
What do you think @gaocegege @johnugeorge @c-bata ?

/cc @richardsliu

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions