Skip to content

Commit 38b1770

Browse files
committed
Add a test for the case 'spec.parameters' is mepty
1 parent 81cf7de commit 38b1770

File tree

1 file changed

+13
-0
lines changed

1 file changed

+13
-0
lines changed

pkg/webhook/v1beta1/experiment/validator/validator_test.go

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -393,6 +393,7 @@ spec:
393393
validTemplate3 := p.EXPECT().GetTrialTemplate(gomock.Any()).Return(validJobStr, nil)
394394
validTemplate4 := p.EXPECT().GetTrialTemplate(gomock.Any()).Return(validJobStr, nil)
395395
validTemplate5 := p.EXPECT().GetTrialTemplate(gomock.Any()).Return(validJobStr, nil)
396+
validTemplate6 := p.EXPECT().GetTrialTemplate(gomock.Any()).Return(validJobStr, nil)
396397

397398
missedParameterTemplate := p.EXPECT().GetTrialTemplate(gomock.Any()).Return(missedParameterJobStr, nil)
398399
oddParameterTemplate := p.EXPECT().GetTrialTemplate(gomock.Any()).Return(oddParameterJobStr, nil)
@@ -408,6 +409,7 @@ spec:
408409
validTemplate3,
409410
validTemplate4,
410411
validTemplate5,
412+
validTemplate6,
411413
missedParameterTemplate,
412414
oddParameterTemplate,
413415
invalidParameterTemplate,
@@ -536,6 +538,17 @@ spec:
536538
Err: true,
537539
testDescription: "Trial template contains Trial parameters which weren't referenced from spec.parameters",
538540
},
541+
// Trial template contains Trial parameters when spec.parameters is empty
542+
{
543+
Instance: func() *experimentsv1beta1.Experiment {
544+
i := newFakeInstance()
545+
i.Spec.Parameters = nil
546+
i.Spec.TrialTemplate.TrialParameters[1].Reference = "wrong-ref"
547+
return i
548+
}(),
549+
Err: false,
550+
testDescription: "Trial template contains Trial parameters when spec.parameters is empty",
551+
},
539552
// Trial Template doesn't contain parameter from trialParameters
540553
// missedParameterTemplate case
541554
{

0 commit comments

Comments
 (0)