Skip to content

Commit 81cf7de

Browse files
committed
Check trial parameter reference only when experiment parameters are not empty
1 parent 059cbbf commit 81cf7de

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

pkg/webhook/v1beta1/experiment/validator/validator.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -292,8 +292,10 @@ func (g *DefaultValidator) validateTrialTemplate(instance *experimentsv1beta1.Ex
292292
trialParametersRefs[parameter.Reference] = true
293293

294294
// Check if parameter reference exist in experiment parameters
295-
if _, ok := experimentParameterNames[parameter.Reference]; !ok {
296-
return fmt.Errorf("parameter reference %v does not exist in spec.parameters: %v", parameter.Reference, instance.Spec.Parameters)
295+
if len(experimentParameterNames) > 0 {
296+
if _, ok := experimentParameterNames[parameter.Reference]; !ok {
297+
return fmt.Errorf("parameter reference %v does not exist in spec.parameters: %v", parameter.Reference, instance.Spec.Parameters)
298+
}
297299
}
298300

299301
// Check if trialParameters contains all substitution for Trial template

0 commit comments

Comments
 (0)