- 
                Notifications
    You must be signed in to change notification settings 
- Fork 10
Setup KFServing project #10
Conversation
| /assign @jlewi | 
| /assign @jlewi | 
| name: mentor-owners | ||
| spec: | ||
| # replace ${PROJECT_ID?} with your project name | ||
| member: "group:[email protected]" | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this group exist?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now; its probably easier to list individual members and use GitOps to sync them. This way policy changes are applied automatically once the PR is merged.
We don't have auto-sync'ing for groups yet.
kubeflow/internal-acls#22
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jlewi what should be the value here? I am using the @kubeflow/kfserving-owners group
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now; its probably easier to list individual members and use GitOps to sync them. This way policy changes are applied automatically once the PR is merged.
We don't have auto-sync'ing for groups yet.
kubeflow/internal-acls#22
ok changing to individuals now, is that a comma separated github ids?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jlewi I just add myself for now see if that works, can you review?
| /lgtm | 
| [APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here 
Needs approval from an approver in each of these files:
 
 Approvers can indicate their approval by writing  | 
| @yuzisun It looks like KFServing already has a test project "kfserving-test" | 
| @yuzisun If you need help to figure out what's going on with the sync [email protected] should be the admins of project kf-kcc-admin . The kfserving project wasn't created because it already exists  | 

This is to address the quota issue for KFServing kubeflow/testing#749