Skip to content
This repository was archived by the owner on Aug 9, 2024. It is now read-only.

Conversation

@yuzisun
Copy link
Member

@yuzisun yuzisun commented Aug 22, 2020

This is to address the quota issue for KFServing kubeflow/testing#749

@k8s-ci-robot k8s-ci-robot requested a review from jlewi August 22, 2020 12:08
@kubeflow-bot
Copy link

This change is Reviewable

@yuzisun
Copy link
Member Author

yuzisun commented Aug 22, 2020

/assign @jlewi

@yuzliu
Copy link

yuzliu commented Aug 22, 2020

/assign @jlewi

name: mentor-owners
spec:
# replace ${PROJECT_ID?} with your project name
member: "group:[email protected]"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this group exist?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now; its probably easier to list individual members and use GitOps to sync them. This way policy changes are applied automatically once the PR is merged.

We don't have auto-sync'ing for groups yet.
kubeflow/internal-acls#22

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jlewi what should be the value here? I am using the @kubeflow/kfserving-owners group

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now; its probably easier to list individual members and use GitOps to sync them. This way policy changes are applied automatically once the PR is merged.

We don't have auto-sync'ing for groups yet.
kubeflow/internal-acls#22

ok changing to individuals now, is that a comma separated github ids?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jlewi I just add myself for now see if that works, can you review?

@jlewi
Copy link
Contributor

jlewi commented Aug 25, 2020

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jlewi
Copy link
Contributor

jlewi commented Aug 25, 2020

@yuzisun It looks like KFServing already has a test project "kfserving-test"

@jlewi
Copy link
Contributor

jlewi commented Aug 25, 2020

@yuzisun If you need help to figure out what's going on with the sync [email protected] should be the admins of project kf-kcc-admin .

The kfserving project wasn't created because it already exists

 Warning  UpdateFailed  6m30s (x25 over 128m)  project-controller  Update call failed: error applying desired state: error creating project kfserving (kfserving): googleapi: Error 409: Requested entity already exists, alreadyExists. If you received a 403 error, make sure you have the `roles/resourcemanager.projectCreator` permission

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants