Add Documentation for Recommendation #732
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 3cc75a4): https://kubedb-v2-hugo--pr732-recommendation-qb9yu3du.web.app (expires Fri, 15 Aug 2025 12:02:03 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 0f29ae8ae0bd54a99bf2b223b6833be47acd5943 |
raihankhan
force-pushed
the
recommendation
branch
5 times, most recently
from
ef0ab9f to
06dc42a
Compare
raihankhan
force-pushed
the
recommendation
branch
2 times, most recently
from
0719db5 to
d24d3fd
Compare
raihankhan
requested review from
souravbiswassanto,
obaydullahmhs and
ArnobKumarSaha
Signed-off-by: raihankhan <[email protected]>
Signed-off-by: raihankhan <[email protected]>
Signed-off-by: raihankhan <[email protected]>
Signed-off-by: raihankhan <[email protected]>
Signed-off-by: raihankhan <[email protected]>
tamalsaha
force-pushed
the
recommendation
branch
from
d24d3fd to
c368ff2
Compare
Signed-off-by: Arnob Kumar Saha <[email protected]>
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 17098337 | Triggered | Generic Password | 2fda6b6 | docs/examples/postgres/gitops/pg-rotate-auth.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
| ```bash | ||
| $ kubectl get elasticsearchopsrequest -n es elastic-1740475409-rotate-auth-auto -w | ||
| NAME TYPE STATUS AGE | ||
| elastic-1740475409-rotate-auth-auto UpdateVersion Progressing 3m12s |
There was a problem hiding this comment.
Type is UpdateVersion. should it be RotateAuth?
| elastic xpack-8.15.0 Ready 10m | ||
| ``` | ||
|
|
||
| Since,duration for client certificate is set as `1h20min`, it is expected that the recommendation engine will generate a rotate-auth recommendation at least after 54 minutes (two-third of lifespan) of the client certificate creation. Once generated you will get a similar recommendation as follows. |
There was a problem hiding this comment.
should it be rotate-auth?
| xpack-8.8.2 8.8.2 ElasticStack ghcr.io/appscode-images/elastic:8.8.2 17h | ||
| ``` | ||
|
|
||
| Let's deploy an Elasticsearch cluster with version `xpack-8.15.0`. We are going to create a cluster topology with 2 master nodes, 3 data nodes and 2 ingest node. We also have to provide an available storageclass for each of the node types. Make sure to have an issuer/clusterIssuer to refer in the manifest. Though KubeDB managed elasticsearch supports TLS in both cert-manager provisioned and Operator provisioned ways, rotate tls only works when certificates are provisioned via cert-manager. |
There was a problem hiding this comment.
rotate tls or reconfigure tls?
| labels: | ||
| app.kubernetes.io/instance: elastic | ||
| app.kubernetes.io/managed-by: kubedb.com | ||
| app.kubernetes.io/type: rotate-tls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.