logger feature can work without knative, in my testing. #453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Zheng <[email protected]>
✅ Deploy Preview for elastic-nobel-0aef7a ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
yuzisun
reviewed
Mar 11, 2025
Comment on lines
+27
to
+29
| !!! Note | ||
| You can create your own message-dumper service, in order to print during testing. Knative is not necessary for this feature. | ||
|
|
There was a problem hiding this comment.
@johnzheng1975 I think it is better to just change to not use knative service as an example here
There was a problem hiding this comment.
I will add later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Fixes #issue-number" or "Add description of the problem this PR solves"
Proposed Changes
pls view kserve/kserve#4128
logger works without knative, current docs may bring confuse.